Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

225 235 Add madeBySystem and madeExecution #226

Merged
merged 21 commits into from
Jul 30, 2024
Merged

225 235 Add madeBySystem and madeExecution #226

merged 21 commits into from
Jul 30, 2024

Conversation

dr-shorthair
Copy link
Collaborator

to sosa-common, and sub-property axioms to ssn-* modules

Add usedActuatingProcedure usedObservingProcedure usedSamplingProcedure to sosa-* modules, and sub-property axioms to ssn-* modules

Add actsOn to sosa-actuation

Closes #225

@dr-shorthair
Add madeBySystem and madeExecution to sosa-common, and sub-property a…
935eeac 
…xioms to ssn-* modules

Add usedActuatingProcedure usedObservingProcedure usedSamplingProcedure to sosa-* modules, and  sub-property axioms to ssn-* modules
Add actsOn to sosa-actuation
@dr-shorthair dr-shorthair linked an issue May 7, 2024 that may be closed by this pull request
madeExecution madeBySystem super-properties used on Execution #225
Closed
@dr-shorthair
Copy link
Collaborator Author

dr-shorthair commented May 21, 2024 •
edited
Loading

Terms in red are the proposed additions, classes in brown are changes we already introduced

System-Execution-Procedure-specializations

@ldesousa
Copy link
Contributor

ldesousa commented May 21, 2024 •
edited by dr-shorthair
Loading

I don't see technical issues with this implementation (yet), but I would like to think a bit more on this from higher level of abstraction. The ontology is moving towards a set of four very similar graphs, centered on the four main classes:

  • Execution
  • Actuation
  • Observation
  • Sampling

Those classes are well defined and understood, not only by those of us in the group, but also to users in general that may deal with concerned datasets in this context. However, the semantic nuances between the sub-classes of Procedure and Property are less evident, i.e.:

  • ActuatingProcedure
  • ObservingProcedure
  • SamplingProcedure
  • ActuableProperty
  • ObservableProperty
  • SamplingProperty

Are all those classes necessary? Do they all have a well defined and unique semantic definition?

Finally coming to the predicates: are they all semantically unique? Or is a single predicate object property between Execution and Procedure enough to convey that relation in all sub-graphs? I would rather have a leaner ontology, with as many elements as possible at the Execution (abstract?) level, only to be specialised in case of objective semantic differences.

Thoughts?

@dr-shorthair
Copy link
Collaborator Author

dr-shorthair commented May 22, 2024 •
edited
Loading

Thanks @ldesousa - this is exactly the conversation we need. Please continue over in #225

@dr-shorthair
Merge branch 'gh-pages' into 225-madebysystem
58cb163 
# Conflicts:
#	ssn/index.html
@dr-shorthair
Merge branch 'gh-pages' into 225-madebysystem
20cde33 
# Conflicts:
#	ssn/images/Actuation.png
#	ssn/images/Observation.png
#	ssn/images/System.png
#	ssn/images/System.svg
#	ssn/index.html
#	ssn/rdf/ontology/core/sosa-actuation.ttl
@dr-shorthair dr-shorthair marked this pull request as draft July 2, 2024 08:11
@dr-shorthair dr-shorthair mentioned this pull request Jul 2, 2024
Closed
@oldskeptic
Copy link
Contributor

Now we have introduced a generalization Execution, and specializations ActuatingProcedure, ObservingProcedure, SamplingProcedure (note that ActuatableProperty and ObservableProperty were there before). The proposed predicates (in red above) are really just my chasing through the consequences.

Do we need the specializations ActuatingProcedure, ObservingProcedure, SamplingProcedure? Is there a material difference in these classes that wouldn't be covered by Procedure? A bit late for this question I realise.

@dr-shorthair
Merge branch 'gh-pages' into 225-madebysystem
5b95524 
# Conflicts:
#	ssn/chapters/Actuation.html
#	ssn/chapters/Common.html
#	ssn/chapters/Observation.html
#	ssn/chapters/Sampling.html
#	ssn/images/Actuation.png
#	ssn/images/Execution.png
#	ssn/images/Observation.png
#	ssn/images/System.png
#	ssn/index.html
#	ssn/rdf/ontology/core/sosa-actuation.ttl
#	ssn/rdf/ontology/core/sosa-common.ttl
#	ssn/rdf/ontology/core/sosa-observation.ttl
#	ssn/rdf/ontology/core/sosa-sampling.ttl
#	ssn/rdf/ontology/core/sosa.ttl
#	ssn/rdf/ontology/core/ssn-actuation.ttl
#	ssn/rdf/ontology/core/ssn-observation.ttl
#	ssn/rdf/ontology/core/ssn-sampling.ttl
@dr-shorthair
Copy link
Collaborator Author

dr-shorthair commented Jul 14, 2024 •
edited
Loading

I've copied this discussion back to issue #225 - better to have it there rather than on the PR.
Please lets keep the high-level discussion there.
PR comments should only be on whether the PR addresses the agreed resolution.

@dr-shorthair
Moved ObservingProcedure and Sampling Procedure back to sosa-oms: nam…
fb150af 
…espace

Additional text on Execution and System to emphasize that they are generalized/abstract classes and that individuals in applications should use sub-classes.
New diagram in overview establishing the generalized Execution pattern.
@dr-shorthair
Remove specialized procedures from diagrams
44382f5
@dr-shorthair
Copy link
Collaborator Author

dr-shorthair commented Jul 18, 2024 •
edited
Loading

Preview https://raw.githack.com/w3c/sdw-sosa-ssn/225-madebysystem/ssn/index.html

Closes #225
Closes #235

@dr-shorthair dr-shorthair marked this pull request as ready for review July 18, 2024 12:44
@dr-shorthair dr-shorthair added the enhancement New feature or request label Jul 18, 2024
@dr-shorthair dr-shorthair changed the title Add madeBySystem and madeExecution 225 235 Add madeBySystem and madeExecution Jul 18, 2024
@dr-shorthair
Includes madeBySystem/madeExecution sub-property relationships
20a9afb 
Add notes about non-use of abstract properties
rob-metalinkage
rob-metalinkage previously requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text clarification should be emphasised as SHOULD NOT

@dr-shorthair
Copy link
Collaborator Author

@rob-metalinkage - fixed

ldesousa
ldesousa requested changes Jul 22, 2024
View reviewed changes
ssn/rdf/ontology/core/sosa-common.ttl Outdated Show resolved Hide resolved
ssn/rdf/ontology/core/sosa-common.ttl Outdated Show resolved Hide resolved
ssn/rdf/ontology/core/sosa-common.ttl Outdated Show resolved Hide resolved
ssn/rdf/ontology/core/sosa-common.ttl Outdated Show resolved Hide resolved
ssn/rdf/ontology/core/sosa-common.ttl Outdated Show resolved Hide resolved
ssn/chapters/Common.html Outdated Show resolved Hide resolved
ssn/chapters/Common.html Outdated Show resolved Hide resolved
ssn/chapters/Common.html Outdated Show resolved Hide resolved
ssn/chapters/Common.html Outdated Show resolved Hide resolved
ssn/images/System.svg Outdated Show resolved Hide resolved
@ldesousa ldesousa mentioned this pull request Jul 24, 2024
Closed
KathiSchleidt
KathiSchleidt reviewed Jul 24, 2024
View reviewed changes
ssn/images/Execution.svg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has specialized Procedure Types

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG all obsolete. Ignore (removed).

@dr-shorthair dr-shorthair dismissed rob-metalinkage’s stale review July 30, 2024 23:48

Changes implemented as requested

@dr-shorthair dr-shorthair merged commit 0067a67 into gh-pages Jul 30, 2024
1 check passed
@dr-shorthair dr-shorthair deleted the 225-madebysystem branch July 30, 2024 23:48
@dr-shorthair dr-shorthair mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldesousa ldesousa ldesousa approved these changes

@oldskeptic oldskeptic oldskeptic approved these changes

@kjano kjano Awaiting requested review from kjano

@maximelefrancois86 maximelefrancois86 Awaiting requested review from maximelefrancois86

@avillar avillar Awaiting requested review from avillar

@rob-metalinkage rob-metalinkage Awaiting requested review from rob-metalinkage

@hylkevds hylkevds Awaiting requested review from hylkevds

@KathiSchleidt KathiSchleidt Awaiting requested review from KathiSchleidt

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0 Public Working Draft
Development

Successfully merging this pull request may close these issues.

madeExecution madeBySystem super-properties used on Execution
5 participants
@dr-shorthair @ldesousa @oldskeptic @rob-metalinkage @KathiSchleidt