239 operating survival ranges, closes #239 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes. Add example on survival and measurement range.
ldesousa
previously requested changes
Oct 21, 2024
|
@ldesousa If we are going to move away from schema.org for values, and I don't have a strong opinion either way, we need to change most of the examples as this is what they are currently using. |
|
From meeting, we use |
dr-shorthair
approved these changes
Dec 11, 2024
dr-shorthair
dismissed
ldesousa’s stale review
Discussed in multiple telecons. Agreed to resolve and merge following final changes after 2024-12-11 telecon
|
@sgrellet @nicholascar @ldesousa Can one of you push the button so we can merge? |
|
@oldskeptic Sorry, I could not look into this yet. Can it wait for next week? |
dr-shorthair
changed the title
ldesousa
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
To revisit InkBird-IBS-TH2-Range.ttl in a subsequent issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements abstract range class for relevant classes is ssn-system.
I notice that when we talk about a "Survival Range" or "Measurement Range", we don't link it to the Observable Property that the range should be applied to. Dragging @KathiSchleidt into this.