NNotepad: Pass buffers rather than views when building constants #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building constants, either a raw ArrayBuffer can be passed or a view type like Float32Array. In the latter case the data type and view type must match; e.g. if dataType is "int8", a Uint8Array must be passed. Chromium is in the process of rolling out native Float16Array support, but currently the WebNN prototype implementation[1] requires passing a Uint16Array if the data type is "float16". NNotepad utilizes this workaround if native Float16Array is not present. But if it *is* present, it passes a native Float16Array and Chromium throws. Until things settle, have NNotepad's constant() builder just pass the underlying buffer rather than view, which bypasses this check. This change can be reverted at some point in the future, but is harmless to continue using this workaround. 1: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/ml/webnn/ml_graph_utils.cc;l=92
|
@Honry - can you please take a look? |
|
FYI I was testing with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building constants, either a raw ArrayBuffer can be passed or a view type like Float32Array. In the latter case the data type and view type must match; e.g. if dataType is "int8", a Uint8Array must be passed.
Chromium is in the process of rolling out native Float16Array support, but currently the WebNN prototype implementation[1] requires passing a Uint16Array if the data type is "float16". NNotepad utilizes this workaround if native Float16Array is not present. But if it is present, it passes a native Float16Array and Chromium throws.
Until things settle, have NNotepad's constant() builder just pass the underlying buffer rather than view, which bypasses this check. This change can be reverted at some point in the future, but is harmless to continue using this workaround.
1: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/ml/webnn/ml_graph_utils.cc;l=92