-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #373: ANIm should not be symmetric #376
base: master
Are you sure you want to change the base?
Conversation
What is the reason for retaining and skipping them? I would have thought deleting/removing the tests would be appropriate. |
I wanted to think a bit about whether there might be a different use for it (there's really only one such test), or whether it might be usefully repurposed before completely removing it. |
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 75.82% 75.77% -0.05%
==========================================
Files 55 55
Lines 3747 3740 -7
==========================================
- Hits 2841 2834 -7
Misses 906 906 |
This code assumed symmetry from anim
With this PR, ANIm is no longer treated as symmetric. Comparisons between each pair of genomes are run in both directions; enforced sorting of output file names has been disabled; tests relying on this sorting are skipped; and documentation has been updated.
Closes #373.
Type of change
Action Checklist
pyani
repository under your own account (please allow write access for repository maintainers)CONTRIBUTING.md
)pytest -v
non-passing code will not be mergedorigin/master
flake8
andblack
before submissionPull requests
section in thepyani
repository