-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FileCard component [WPB-15686] #18692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafsulich
changed the title
feat: FileCard component
feat: FileCard component [WPB-15686]
Jan 31, 2025
aweiss-dev
approved these changes
Jan 31, 2025
waseemansar
approved these changes
Jan 31, 2025
V-Gira
reviewed
Jan 31, 2025
src/script/components/FileCard/FileCardError/FileCardError.styles.ts
Outdated
Show resolved
Hide resolved
thisisamir98
approved these changes
Jan 31, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic
FileCard
component. It's created in the "compound components" style, with customizability in mind, inspired by libraries like Radix UI.Because of the many options and file types, the component must be open to changes. It'll be used inside
InputBar
for uploading and in the message content.It's an MVP and will be used for the Cells, but we plan to introduce new cards also for the conversations without Cells. Some things can change, like the list of extensions.
With the options menu:
With the close button:
With the loading indicator:
With additional content (e.g. pdf preview):
Multiple formats:
Checklist