Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FileCard component [WPB-15686] #18692

Merged
merged 8 commits into from
Jan 31, 2025
Merged

feat: FileCard component [WPB-15686] #18692

merged 8 commits into from
Jan 31, 2025

Conversation

olafsulich
Copy link
Contributor

@olafsulich olafsulich commented Jan 30, 2025

TaskWPB-15686 [Web] File cards

Description

Generic FileCard component. It's created in the "compound components" style, with customizability in mind, inspired by libraries like Radix UI.

Because of the many options and file types, the component must be open to changes. It'll be used inside InputBar for uploading and in the message content.

It's an MVP and will be used for the Cells, but we plan to introduce new cards also for the conversations without Cells. Some things can change, like the list of extensions.


With the options menu:
image

With the close button:
Screenshot 2025-01-31 at 09 29 17

With the loading indicator:
image

With additional content (e.g. pdf preview):

image

Multiple formats:
image

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@olafsulich olafsulich changed the title feat: FileCard component feat: FileCard component [WPB-15686] Jan 31, 2025
@olafsulich olafsulich marked this pull request as ready for review January 31, 2025 08:31
@olafsulich olafsulich requested review from otto-the-bot and a team as code owners January 31, 2025 08:31
@olafsulich olafsulich merged commit 5a3f076 into dev Jan 31, 2025
12 of 14 checks passed
@olafsulich olafsulich deleted the feat/file-type-tile branch January 31, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants