fix(applock): prevent unintentional logout when applock is active [15545] #18698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
V-Gira
commented
Jan 31, 2025
| @@ -156,11 +159,16 @@ const AppLock: React.FC<AppLockProps> = ({ | |||
| app?.style.setProperty('pointer-events', isVisible ? 'none' : 'auto', 'important'); | |||
|
|
|||
| if (isVisible) { | |||
| modalObserver.observe(document.querySelector('#wire-main'), { | |||
| childList: true, | |||
| subtree: true, | |||
There was a problem hiding this comment.
I was unable to pinpoint the exact cause, but this observer was checking for both childList and subtree for a removal attempt of the modal.
It doesn't seem to be necessary to include the subtree with our current code structure, as the app correctly logs out when removing the app lock modal from the DOM
aweiss-dev
approved these changes
Feb 2, 2025
olafsulich
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The app would log out on app initialization for team users if app lock is active, without giving them the chance to disable app lock
There is an observer that makes sure the app or the modal is not tempered with to prevent people to simply removing the app lock from the DOM
It appears the observer is too aggressive, and would logout a user automatically
Checklist