fix issue with intialPage in Carousel not working

wix · Nov 18, 2019 · d596c13 · d596c13
1 parent 95b2de3
commit d596c13
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/demo/src/screens/componentScreens/CarouselScreen.js b/demo/src/screens/componentScreens/CarouselScreen.js
@@ -3,7 +3,7 @@ import {StyleSheet} from 'react-native';
 import {Constants, View, Text, Carousel, Image, Card} from 'react-native-ui-lib'; // eslint-disable-line
 import _ from 'lodash';
 
-const INITIAL_PAGE = 0;
+const INITIAL_PAGE = 2;
 const WIDTH = Constants.screenWidth - 120;
 
 const IMAGES = [
@@ -39,7 +39,7 @@ class CarouselScreen extends Component {
           onChangePage={index => this.onChangePage(index)}
           pageWidth={WIDTH}
           // itemSpacings={20}
-          // initialPage={INITIAL_PAGE}
+          initialPage={INITIAL_PAGE}
           containerStyle={{height: 160/* , flex: 1 */}}
           pageControlPosition={'under'}
           pageControlProps={{onPagePress: this.onPagePress}}
@@ -73,7 +73,7 @@ class CarouselScreen extends Component {
         </View>
 
         <View padding-20>
-          <Carousel test migrate containerStyle={{height: 160}}>
+          <Carousel migrate containerStyle={{height: 160}} initialPage={INITIAL_PAGE} loop>
             {_.map(IMAGES, (image, index) => {
               return (
                 <View key={index} flex padding-10 bottom>

diff --git a/src/components/carousel/index.js b/src/components/carousel/index.js
@@ -156,20 +156,28 @@ export default class Carousel extends BaseComponent {
       const snapToOffsets = _.times(presenter.getChildrenLength(this.props), index => initialBreak + index * pageWidth);
       return snapToOffsets;
     }
-  }
+  };
 
   shouldUsePageWidth() {
     const {loop, pageWidth} = this.props;
     return !loop && pageWidth;
   }
 
-  onContainerLayout = ({nativeEvent: {layout: {width: containerWidth}}}) => {
+  onContainerLayout = ({
+    nativeEvent: {
+      layout: {width: containerWidth}
+    }
+  }) => {
+    const {initialPage, pageWidth} = this.props;
     const update = {containerWidth};
-    if (!this.props.pageWidth) {
+    if (!pageWidth) {
       update.pageWidth = containerWidth;
+      update.initialOffset = {
+        x: presenter.calcOffset(this.props, {currentPage: initialPage, pageWidth: containerWidth})
+      };
     }
     this.setState(update);
-  }
+  };
 
   onContentSizeChange = () => {
     // this is to handle initial scroll position (content offset)