forked from woowacourse-precourse/javascript-oncall-6
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[개발자 비상 근무] 박상우 미션 제출합니다. #3
Open
SangWoo9734
wants to merge
22
commits into
woowacourse-7th-pair-study:main
Choose a base branch
from
SangWoo9734:SangWoo9734
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[개발자 비상 근무] 박상우 미션 제출합니다. #3
SangWoo9734
wants to merge
22
commits into
woowacourse-7th-pair-study:main
from
SangWoo9734:SangWoo9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 추가한 로직 - 숫자인지 - 적절한 월이 입력되었는지 - 유효한 요일이 입력되었는지 - 근무자 이름이 5자 이내인지 - 근무자가 5명 이상 35명 이하로 입력되었는지 - 에러 메세지 출력을 위한 errorHandle 추가 - Validator에 필요한 상수값 분리 ( costants.js )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
신경쓴 점
아쉬운 점