Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Noah-MP tag for v4.7 with bug fixes #2160

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

cenlinhe
Copy link
Contributor

@cenlinhe cenlinhe commented Jan 25, 2025

Update Noah-MP tag for v4.7 with bug fixes (only Noah-MP source code is changed in Noah-MP GitHub)

TYPE: bug fix

KEYWORDS: snow albedo, soil timestep, glacier heat capacity

SOURCE: Cenlin He (NCAR)

DESCRIPTION OF CHANGES:
Bug fixes for the following three parts:

  1. allow BATS snow albedo scheme for nighttime snow aging: Bug fix in physics/module_sf_noahmp_glacier.F90: only compute glacier albedo in snowalb_bats_glacier if cosz > 0 NCAR/ccpp-physics#1091
  2. fix the potential leakage caused by calculate_soil variable during parallelization: Prevent stale values of calculate_soil from leaking across threads NCAR/noahmp#136
  3. fix the missing of HCPCT output for glacier points: bug fix for HCPCT variable for glacierized grid cells (issue #140) NCAR/noahmp#141

LIST OF MODIFIED FILES:
phys/noahmp

TESTS:
The changes have passed the regression tests.

RELEASE NOTE: Noah-MP bug fixes for (1) allowing BATS snow albedo scheme for nighttime snow aging, (2) the potential leakage caused by calculate_soil variable during parallelized run, (3) the missing of HCPCT output for glacier points.

@cenlinhe cenlinhe requested a review from a team as a code owner January 25, 2025 17:53
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar merged commit fd079bf into wrf-model:develop Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants