-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve action execution core #6262
Improve action execution core #6262
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6262 +/- ##
============================================
+ Coverage 45.72% 46.20% +0.47%
- Complexity 14065 15015 +950
============================================
Files 1633 1675 +42
Lines 100705 106905 +6200
Branches 17706 18767 +1061
============================================
+ Hits 46045 49391 +3346
- Misses 47959 50517 +2558
- Partials 6701 6997 +296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1d4b9c8
to
4e32383
Compare
4e32383
to
b0be613
Compare
...tion.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/Incomplete.java
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
2cd2670
to
4b0b14d
Compare
PR builder started |
PR builder completed |
...rc/main/java/org/wso2/carbon/identity/action/execution/ActionExecutionResponseProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
...tion.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/Incomplete.java
Outdated
Show resolved
Hide resolved
770a0e3
to
8a19f3c
Compare
4f896b4
to
cabe798
Compare
...tion.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/Incomplete.java
Outdated
Show resolved
Hide resolved
...execution/src/main/java/org/wso2/carbon/identity/action/execution/ActionExecutorService.java
Outdated
Show resolved
Hide resolved
...java/org/wso2/carbon/identity/action/execution/model/ActionInvocationIncompleteResponse.java
Outdated
Show resolved
Hide resolved
...execution/src/main/java/org/wso2/carbon/identity/action/execution/ActionExecutorService.java
Outdated
Show resolved
Hide resolved
b3ece61
to
e6e74dd
Compare
.../src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
7b1370e
to
4520911
Compare
|
PR builder started |
PR builder completed |
.../test/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImplTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImplTest.java
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12887152107
Issue:
With this PR following improvements will be added to the action exection core.
Add INCOMPLETE action invocation status. Eg: In the custom authentication, the external service will be want to redirect user to custom page. There we can utilize this new INCOMPLETE state with REDIRECT operation.
This will bring the Bring following method which execute the action id list to its interface.