Interpreter improvements (wip) #269
Draft
+98
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 04479a8): https://gcode-preview--pr269-fix-webggl-errors-556n7yvx.web.app (expires Wed, 26 Feb 2025 21:23:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
remcoder
force-pushed
the
fix/webggl-errors
branch
from
2352bf5 to
04479a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempted to address #257 but I couldn't pinpoint those errors.
This PR mainly addresses 'non-moving movement commands' and zero-length path. Skipping these is a non trivial amount of cycles and data so it is decent a performance improvement.
Non-moving move commands, for exameple:
G0 F2000, specify no value for X,Y an Z. Therefore they are not rendered as a line anyway. Skipping these results in no visible difference. Yet these account for about 30% of the input.TODO: