Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add namespace support to generator #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rikkuness
Copy link

A work in progress attempt at a fix for #22 .

This seems to work okay for v1.0 but currently is broken when generating for beta.

The generator runs for beta but I think that it has perhaps conflicts in the names of types? I'm not sure the best way to approach this, should the different namespaces be under their own structure, for example github.com/yaegashi/msgraph.go/beta/callRecords for the microsoft.graph.callRecords namespace?

@DonovanCharpin
Copy link

Hi @rikkuness, did you manage to fix this issue?

@kim-at-thirdlight
Copy link

This still seems to have issues with item names from the inconsistent renaming of entities ending in Request. If you move the request object name-change logic to exported(), as in:
kim-at-thirdlight@f4ccfc5

This will fix most of the issues. Note this commit is is from a branch that attempted to fix the namespacing issue in a much less elegant manner, please ignore it 😅

There does still seem to be some issues in beta with repeat definitions of DeviceManagementTemplateSettingsCollectionRequest though... I will further look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants