卸载修改为.unmount()

yaklang · Dec 28, 2023 · 11ca99a · 11ca99a
1 parent c50e4f3
commit 11ca99a
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 29 deletions.
diff --git a/app/renderer/src/main/src/components/yakitUI/YakitDrawer/YakitDrawer.tsx b/app/renderer/src/main/src/components/yakitUI/YakitDrawer/YakitDrawer.tsx
@@ -80,13 +80,6 @@ export const showYakitDrawer = (props: ShowDrawerProps) => {
                         onVisibleSetter={(r) => {
                             setter = r
                         }}
-                        // afterClose={() => {
-                        //     if (props.modalAfterClose) props.modalAfterClose()
-                        //     const unmountResult = ReactDOM.unmountComponentAtNode(div)
-                        //     if (unmountResult && div.parentNode) {
-                        //         div.parentNode.removeChild(div)
-                        //     }
-                        // }}
                     >
                         <ErrorBoundary
                             FallbackComponent={({error, resetErrorBoundary}) => {

diff --git a/app/renderer/src/main/src/components/yakitUI/YakitModal/YakitModalConfirm.tsx b/app/renderer/src/main/src/components/yakitUI/YakitModal/YakitModalConfirm.tsx
@@ -37,10 +37,11 @@ export const YakitModalConfirm = (props: YakitModalConfirmProps) => {
                         }}
                         afterClose={() => {
                             if (props.modalAfterClose) props.modalAfterClose()
-                            const unmountResult = ReactDOM.unmountComponentAtNode(div)
-                            if (unmountResult && div.parentNode) {
-                                div.parentNode.removeChild(div)
-                            }
+                            setTimeout(() => {
+                                if (yakitModalConfirmRootDiv) {
+                                    yakitModalConfirmRootDiv.unmount()
+                                }
+                            })
                         }}
                         title={null}
                         headerStyle={{paddingBottom: 0}}
@@ -221,10 +222,11 @@ export const showYakitModal = (props: ShowModalProps) => {
                         }}
                         afterClose={() => {
                             if (props.modalAfterClose) props.modalAfterClose()
-                            const unmountResult = ReactDOM.unmountComponentAtNode(div)
-                            if (unmountResult && div.parentNode) {
-                                div.parentNode.removeChild(div)
-                            }
+                            setTimeout(() => {
+                                if (yakitModalRootDiv) {
+                                    yakitModalRootDiv.unmount()
+                                }
+                            })
                         }}
                     >
                         <ErrorBoundary

diff --git a/app/renderer/src/main/src/utils/showByCursor.tsx b/app/renderer/src/main/src/utils/showByCursor.tsx
@@ -84,11 +84,10 @@ export const showByCursorMenu = (props: ByCursorMenuProp, x: number, y: number)
     div.id = cursorMenuId
     div.className = "popup"
     document.body.appendChild(div)
-
+    let cursorMenuRootDiv
     const destory = () => {
-        const unmountResult = ReactDOM.unmountComponentAtNode(div)
-        if (unmountResult && div.parentNode) {
-            div.parentNode.removeChild(div)
+        if (cursorMenuRootDiv) {
+            cursorMenuRootDiv.unmount()
         }
     }
 
@@ -98,8 +97,12 @@ export const showByCursorMenu = (props: ByCursorMenuProp, x: number, y: number)
                 destory()
                 document.removeEventListener("click", onClickOutsize)
             })
-            if ((props.content || []).length > 0)
-                createRoot(div).render(
+            if ((props.content || []).length > 0) {
+                if (!cursorMenuRootDiv) {
+                    cursorMenuRootDiv = createRoot(div)
+                }
+
+                cursorMenuRootDiv.render(
                     <Menu
                         className={"right-cursor-menu"}
                         onClick={(item: {key: string}) => {
@@ -147,6 +150,7 @@ export const showByCursorMenu = (props: ByCursorMenuProp, x: number, y: number)
                         })}
                     </Menu>
                 )
+            }
         })
     }
     render()

diff --git a/app/renderer/src/main/src/utils/showModal.tsx b/app/renderer/src/main/src/utils/showModal.tsx
@@ -59,10 +59,11 @@ export const showModal = (props: ShowModalProps) => {
                         }}
                         afterClose={() => {
                             if (props.modalAfterClose) props.modalAfterClose()
-                            const unmountResult = ReactDOM.unmountComponentAtNode(div)
-                            if (unmountResult && div.parentNode) {
-                                div.parentNode.removeChild(div)
-                            }
+                            setTimeout(() => {
+                                if (modalRootDiv) {
+                                    modalRootDiv.unmount()
+                                }
+                            })
                         }}
                     >
                         <ErrorBoundary
@@ -166,10 +167,11 @@ export const showDrawer = (props: ShowDrawerProps) => {
                             onDestroy = setter
                         }}
                         afterClose={() => {
-                            const unmountResult = ReactDOM.unmountComponentAtNode(div)
-                            if (unmountResult && div.parentNode) {
-                                div.parentNode.removeChild(div)
-                            }
+                            setTimeout(() => {
+                                if (drawerRootDiv) {
+                                    drawerRootDiv.unmount()
+                                }
+                            })
                         }}
                     >
                         {targetConfig.content}