Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nscd-related Code #400

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove nscd-related Code #400

merged 2 commits into from
Jan 28, 2025

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented Jan 28, 2025

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1236308

Trello

https://trello.com/c/3Auiiwx8/

Problem

nscd is now dropped from Factory / Tumbleweed. YaST should not do any nscd-related actions anymore.

GitHub Search

https://github.com/search?q=org%3Ayast+nscd+language%3APerl&type=code&l=Perl

https://github.com/search?q=org%3Ayast+nscd+language%3ARuby&type=code&l=Ruby

Fix

Remove all code in sources and tests that refers to nscd, no matter if it's about the package, the system user account, or the user group, so future GitHub searches in YaST code will no longer get any hits for the nscd search term.

Affected Branches / Products

Only Factory / Tumbleweed.

Related PRs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13007805291

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on huha-remove-nscd at 60.368%

Totals Coverage Status
Change from base Build 11140394631: 60.4%
Covered Lines: 3409
Relevant Lines: 5647

💛 - Coveralls

Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yay less dead code!

@shundhammer shundhammer merged commit eea201b into master Jan 28, 2025
12 checks passed
@shundhammer shundhammer deleted the huha-remove-nscd branch January 28, 2025 10:53
Copy link

✅ Autosubmission job #13008863494 successfully finished
✅ Created submit request #1240798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants