tests: Tests with different file formats #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmammeri
reviewed
Oct 1, 2024
| #[test_case("simple.pptx", 0.9; "Test another PPTX file")] | ||
| #[test_case("table-multi-row-column-cells.png", -1.0; "Test PNG file")] | ||
| #[test_case("winter-sports.epub", 0.9; "Test EPUB file")] | ||
| fn test_extractor(file_name: &str, target_dist: f64) { |
There was a problem hiding this comment.
I would name this test_extract_file_to_string as it is testing the extract to string functionality.
| .extract_file_to_string(&format!("../test_files/documents/{}", file_name)) | ||
| .unwrap(); | ||
| // read expected string | ||
| let mut expected = |
There was a problem hiding this comment.
doesn't need to be mutable
| fn test_extractor(file_name: &str, target_dist: f64) { | ||
| let extractor = Extractor::new().set_extract_string_max_length(1000000); | ||
| // extract file with extractor | ||
| let mut extracted = extractor |
There was a problem hiding this comment.
doesn't need to be mutable
| @@ -23,7 +23,7 @@ requires-python = ">=3.8,<3.13" | |||
| docs = ["pdoc"] | |||
| # To run tests using pytest we need to run: | |||
| # pytest -s | |||
| test = ["pytest"] | |||
| test = ["pytest","sklearn"] | |||
There was a problem hiding this comment.
pip was reporting that sklearn is deprecated and should be replaced by scikit-learn
There was a problem hiding this comment.
may be rename the file to test_extract_file_to_string.py pytest shows the filename on the console. It would be better to know which test it is from the console output.
* test documents and expected results are in test_files dir * integration tests for rust interface * integration tests for python interface * tested formats: pdf, docx, pptx, doc, odt, pptx, csv, png, xlsx, epub Issue-ID: 2
KapiWow
force-pushed
the
2-tests-for-different-formats
branch
from
baca44b to
69a24ed
Compare
|
All comments are adressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-ID: 2
The test files were taken from an unstructured repository, and the expected result files were also generated by the unstructured library. Hopefully their library works well with their test files.
I used cosine_similarity because Levenshtein takes about 20 seconds to process the similarity of the extracted PDF text.