#15: 生成したQRコード画像をクリップボードへコピーできるように対応 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytak-sagit
commented
Dec 29, 2024
| @@ -52,6 +53,7 @@ struct QrCodeProps { | |||
| #[function_component(QrCodeImage)] | |||
| fn qr_code_image(props: &QrCodeProps) -> Html { | |||
| let QrCodeProps { url } = props.clone(); | |||
| let clipboard = use_clipboard(); | |||
There was a problem hiding this comment.
Note
hooks は常に呼ばれる形でないと、Hooks was called conditionally. といったエラーが発生する
- 条件付きで hooks が呼ばれたり呼ばれなかったりするのはNG
1 task
ytak-sagit
commented
Dec 29, 2024
| @@ -8,4 +8,5 @@ edition = "2021" | |||
| [dependencies] | |||
| qr-code-wrapper = { path = "./qr-code-wrapper" } | |||
| web-sys = "0.3.76" | |||
| yew = { git = "https://github.com/yewstack/yew/", features = ["csr"] } | |||
| yew = { version = "0.21.0", features = ["csr"] } | |||
There was a problem hiding this comment.
Note
git 参照だと use_clipboard の trait 実装のエラーが発生
version 参照とすることで、上記エラーが解決した
（途中から実装された hooks だった場合、バージョンが固定されてないとコンパイル時に解決できないのかも）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arboardcrate を使用する予定だったが、wasm 非対応だったyew-hookscrate のuse_clipboardを使用するように対応