Skip to content

Commit

Permalink
cosmicds: Fix logs not being generated
Browse files Browse the repository at this point in the history
Turns out us unconditionally setting `jupyterhub-singleuser`
as `cmd` prevents repo2docker's automatic log generation from
working!

Ref 2i2c-org#3109
  • Loading branch information
yuvipanda committed Nov 17, 2023
1 parent aef87de commit e8608f1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions config/clusters/2i2c-aws-us/cosmicds.values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ jupyterhub:
name: Cosmic DS, Harvard
url: https://www.cosmicds.cfa.harvard.edu/
singleuser:
# Unset cmd so repo2docker-entrypoint gets used, and logs actually work
# Ref https://github.com/2i2c-org/infrastructure/issues/3109
cmd: null
# No persistent storage should be kept to reduce any potential data
# retention & privacy issues.
# Ref https://github.com/2i2c-org/infrastructure/issues/2128#issuecomment-1635107926
Expand Down

0 comments on commit e8608f1

Please sign in to comment.