Add support for the Waveshare ESP32-S3-Touch-LCD1.28 board #67311

joelguittet · 2024-01-08T12:59:02Z

The purpose of this Pull Request is to add support for the Waveshare ESP32-S3-Touch-LCD1.28 board.

fabiobaltieri

cool board

drivers/input/input_cst816s.c

boards/xtensa/waveshare_esp32s3_touch_lcd/waveshare_esp32s3_touch_lcd-pinctrl.dtsi

boards/xtensa/waveshare_esp32s3_touch_lcd/waveshare_esp32s3_touch_lcd.dts

boards/xtensa/waveshare_esp32s3_touch_lcd/waveshare_esp32s3_touch_lcd_defconfig

boards/xtensa/waveshare_esp32s3_touch_lcd/waveshare_esp32s3_touch_lcd.dts

fabiobaltieri · 2024-01-08T20:56:37Z

@joelguittet one more thing, you named the board waveshare_esp32s3_touch_lcd but when I see that Waveshare has two "waveshare esp32s3 touch lcd" boards, a 1.28'' and a 4.3'', could you rename the board to something like waveshare_esp32s3_touch_lcd_1_28? (We have a buydisplay_2_8_tft_touch_arduino shield already)

kartben · 2024-01-08T21:04:16Z

@joelguittet one more thing, you named the board waveshare_esp32s3_touch_lcd but when I see that Waveshare has two "waveshare esp32s3 touch lcd" boards, a 1.28'' and a 4.3'', could you rename the board to something like waveshare_esp32s3_touch_lcd_1_28? (We have a buydisplay_2_8_tft_touch_arduino shield already)

It might make sense to keep the generic folder name though so that it can become the home for waveshare_esp32s3_touch_lcd_4_3, should it be added someday?

fabiobaltieri · 2024-01-08T21:11:48Z

It might make sense to keep the generic folder name though so that it can become the home for waveshare_esp32s3_touch_lcd_4_3, should it be added someday?

They really don't have much in common https://files.waveshare.com/wiki/ESP32-S3-Touch-LCD-1.28/ESP32-S3-Touch-LCD-1.28-Sch.pdf https://files.waveshare.com/wiki/ESP32-S3-Touch-LCD-4.3/ESP32-S3-Touch-LCD-4.3-Sch.pdf, normally the board directory is for different revisions or variation with common pinout or stuff like that, but these are really two different boards, they barely use the same chip (one uses a module).

kartben · 2024-01-08T21:19:02Z

Ah! Sorry then :) Product naming is always funny. There I was, thinking only display size would be different based on the names 😅

joelguittet · 2024-01-08T22:14:07Z

Good point, yes I just checked too and they are very different. Will rename this one now.

fabiobaltieri

looks good, guess we have to wait on the display pr

samples/drivers/adc/boards/waveshare_esp32s3_touch_lcd_1_28.overlay

jfischer-no · 2024-01-12T15:47:09Z

samples/subsys/display/lvgl/boards/waveshare_esp32s3_touch_lcd_1_28.conf

@@ -0,0 +1 @@
+CONFIG_MAIN_STACK_SIZE=4096


Ohh, our minimal LVGL sample is not minimal anymore? What is the display resolution? Would you need same one-line-overlay for another LVGL sample?

No the default stack size is not enough. Display is 240x240. I have seen at least one other board with the 4096 stack size.
What do you mean by one line overlay for another lvgl sample ?

joelguittet · 2024-03-20T22:27:15Z

@sylvioalves true! I was waiting other esp32 board to be migrated to have an example and the common soc files I need here. It's now updated here!

The board esp32s3_touch_lcd_1_28/esp32s3/procpu has been tested with the following samples:

samples/hello_world => works fine
samples/drivers/adc/ to read the battery voltage (overlay is provided) => works fine
samples/subsys/display/lvgl/ to check the display and the touchscreen controller => works fine

The board esp32s3_touch_lcd_1_28/esp32s3/appcpu has been tested compiled with the samples/hello_world but it's not booting. esp32s3_devkitm has the same behavior. I guess this is not due to this new waveshare board, but to be honest, I don't know the behavior of the appcpu board / how to test it... if somebody can guide me on this part ?

nordicjm · 2024-03-21T07:57:17Z

This needs to be targeted to main not the collab-hwm branch

fabiobaltieri · 2024-03-21T10:11:17Z

@joelguittet you can change the base of the existing PR, just click edit on the top and the base should become a dropbox and you can pick main there

joelguittet · 2024-03-21T11:35:24Z

@nordicjm @fabiobaltieri are you sure of your request ? If I target main then the PR will show all the commits of the collab hwm branch..... And if my PR is merged then it will merge everything in main including all the collab hwm commits.
Maybe you want me to target main, review only the last 3 commits and wait until collab hwm is merge before merging my PR ? If collab branch is merge and deleted GitHub should automatically retarget this PR to main so should not be blocking? (It s working like that on bitbucket but I m not sure on GitHub to be honest)

Note : I will fix the doc issue reported by the pipeline asap of course.

nordicjm · 2024-03-21T11:42:17Z

You need to rebase it properly so that your changes apply to main, not the collab-hwm branch, so this PR needs to contain just your commits that would clearly apply. collab-hwm was merged weeks ago

fabiobaltieri · 2024-03-21T11:51:58Z

yeah well if you don't change the base it's going to be merged on the branch which is certainly not what you want either :-)

after you change the base the PR may become a giant mess, then you can fix it up locally and force push it again, all normal

joelguittet · 2024-03-21T12:19:15Z

Oh my bad 😞 seems I m tired, just realized the collab hwm branch feature have merged to main branch too...
I was thinking it was not done yet and still a rework in progress
For sure now I will rebase on main !

joelguittet · 2024-03-22T12:30:28Z

Updated :)

nordicjm

Comments are optional

nordicjm · 2024-03-22T12:34:11Z

boards/waveshare/esp32s3_touch_lcd_1_28/esp32s3_touch_lcd_1_28_esp32s3_appcpu.dts

+		scratch_partition: partition@210000 {
+			label = "image-scratch";
+			reg = <0x00210000 0x00040000>;
+		};


Would remove and give to slots instead since swap using scratch is not recommended

Agree but it's retrieved from the esp32s3_devkitm board from Espressif. I guess it's better to keep consistency across similar boards?

@nordicjm what is your opinion?

@sylvioalves

@sylvioalves ? Your opinion about this ? What should be the default in zephyr for this kind of board ?

@nordicjm hey since we are on the topic I'll add a question: do you think it would make sense to have few templates for in-tree board partitions maps? We have a lot of boards based on esp32, nrf52840 etc... and the flash partitioning is pretty much always the same, maybe we can have some dtsi and #include it in the board file? As much as I dislike mid-structure includes, it may be better than repeating this to infinity.

nordicjm · 2024-03-22T12:34:46Z

boards/waveshare/esp32s3_touch_lcd_1_28/esp32s3_touch_lcd_1_28_esp32s3_procpu.dts

+		scratch_partition: partition@210000 {
+			label = "image-scratch";
+			reg = <0x00210000 0x00040000>;
+		};


addressed

joelguittet · 2024-04-07T09:08:18Z

@nordicjm gentle ping for the above question, thanks!

boards/waveshare/esp32s3_touch_lcd_1_28/doc/index.rst

Add support for the Waveshare ESP32-S3-Touch-LCD-1.28 board, including support the LCD and touchscreen controllers. Tested with samples already available. Signed-off-by: Joel Guittet <[email protected]>

Add configuration for the Waveshare ESP32-S3-Touch-LCD-1.28 board. Signed-off-by: Joel Guittet <[email protected]>

joelguittet · 2024-04-25T15:13:45Z

Thanks for the reviews here ! 🎉

zephyrbot added area: Samples Samples area: Display area: ADC Analog-to-Digital Converter (ADC) area: Input Input Subsystem and Drivers labels Jan 8, 2024

zephyrbot requested review from anangl, fabiobaltieri, gmarull, jfischer-no, kartben and nashif January 8, 2024 12:59

zephyrbot assigned kartben Jan 8, 2024

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from 2cd93a6 to 0d93a65 Compare January 8, 2024 13:30

fabiobaltieri reviewed Jan 8, 2024

View reviewed changes

boards/xtensa/waveshare_esp32s3_touch_lcd/waveshare_esp32s3_touch_lcd.dts Outdated Show resolved Hide resolved

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch 2 times, most recently from 5128043 to 2b24650 Compare January 8, 2024 20:47

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch 2 times, most recently from bd14ef5 to 751fbcf Compare January 8, 2024 22:36

fabiobaltieri reviewed Jan 9, 2024

View reviewed changes

samples/drivers/adc/boards/waveshare_esp32s3_touch_lcd_1_28.overlay Outdated Show resolved Hide resolved

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from 751fbcf to 90c647c Compare January 9, 2024 20:24

jfischer-no reviewed Jan 12, 2024

View reviewed changes

joelguittet mentioned this pull request Jan 20, 2024

drivers: display: gc9x01x: Add support for galaxy core gc9a01a display controller #67012

Merged

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from 90c647c to d613574 Compare January 20, 2024 21:42

zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Jan 20, 2024

zephyrbot requested a review from galak January 20, 2024 21:43

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from cbb48bb to ad44654 Compare March 20, 2024 22:31

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from ad44654 to 7cc6fc2 Compare March 22, 2024 11:16

joelguittet changed the base branch from collab-hwm to main March 22, 2024 11:17

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from 7cc6fc2 to 765fd96 Compare March 22, 2024 11:18

nordicjm reviewed Mar 22, 2024

View reviewed changes

fabiobaltieri previously approved these changes Apr 23, 2024

View reviewed changes

kartben reviewed Apr 23, 2024

View reviewed changes

boards/waveshare/esp32s3_touch_lcd_1_28/doc/index.rst Outdated Show resolved Hide resolved

joelguittet dismissed fabiobaltieri’s stale review via 3e30de3 April 24, 2024 19:24

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from 765fd96 to 3e30de3 Compare April 24, 2024 19:24

joelguittet added 3 commits April 24, 2024 21:32

boards: xtensa: add support for waveshare esp32-s3-touch-lcd-1.28

6921627

Add support for the Waveshare ESP32-S3-Touch-LCD-1.28 board, including support the LCD and touchscreen controllers. Tested with samples already available. Signed-off-by: Joel Guittet <[email protected]>

samples: drivers: adc: add esp32-s3-touch-lcd-1.28 overlay

6942544

Add configuration for the Waveshare ESP32-S3-Touch-LCD-1.28 board. Signed-off-by: Joel Guittet <[email protected]>

samples: display: lvgl: add esp32-s3-touch-lcd-1.28 config

36850dc

Add configuration for the Waveshare ESP32-S3-Touch-LCD-1.28 board. Signed-off-by: Joel Guittet <[email protected]>

joelguittet force-pushed the boards/waveshare-esp32s3-touch-lcd branch from 3e30de3 to 36850dc Compare April 24, 2024 19:35

joelguittet requested review from fabiobaltieri and kartben April 25, 2024 08:09

fabiobaltieri approved these changes Apr 25, 2024

View reviewed changes

kartben approved these changes Apr 25, 2024

View reviewed changes

carlescufi merged commit d9e5aa4 into zephyrproject-rtos:main Apr 25, 2024
22 checks passed

joelguittet deleted the boards/waveshare-esp32s3-touch-lcd branch April 25, 2024 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the Waveshare ESP32-S3-Touch-LCD1.28 board #67311

Add support for the Waveshare ESP32-S3-Touch-LCD1.28 board #67311

joelguittet commented Jan 8, 2024 •

edited

Loading

fabiobaltieri left a comment

fabiobaltieri commented Jan 8, 2024

kartben commented Jan 8, 2024

fabiobaltieri commented Jan 8, 2024

kartben commented Jan 8, 2024

joelguittet commented Jan 8, 2024

fabiobaltieri left a comment •

edited

Loading

jfischer-no Jan 12, 2024

joelguittet Jan 12, 2024

joelguittet commented Mar 20, 2024

nordicjm commented Mar 21, 2024

fabiobaltieri commented Mar 21, 2024

joelguittet commented Mar 21, 2024

nordicjm commented Mar 21, 2024 •

edited

Loading

fabiobaltieri commented Mar 21, 2024 •

edited

Loading

joelguittet commented Mar 21, 2024

joelguittet commented Mar 22, 2024

nordicjm left a comment

nordicjm Mar 22, 2024

joelguittet Mar 22, 2024

joelguittet Mar 25, 2024

nordicjm Apr 8, 2024

joelguittet Apr 23, 2024

fabiobaltieri Apr 23, 2024

nordicjm Mar 22, 2024

joelguittet commented Apr 7, 2024

joelguittet commented Apr 25, 2024

		@@ -0,0 +1 @@
		CONFIG_MAIN_STACK_SIZE=4096

Add support for the Waveshare ESP32-S3-Touch-LCD1.28 board #67311

Add support for the Waveshare ESP32-S3-Touch-LCD1.28 board #67311

Conversation

joelguittet commented Jan 8, 2024 • edited Loading

fabiobaltieri left a comment

Choose a reason for hiding this comment

fabiobaltieri commented Jan 8, 2024

kartben commented Jan 8, 2024

fabiobaltieri commented Jan 8, 2024

kartben commented Jan 8, 2024

joelguittet commented Jan 8, 2024

fabiobaltieri left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joelguittet commented Mar 20, 2024

nordicjm commented Mar 21, 2024

fabiobaltieri commented Mar 21, 2024

joelguittet commented Mar 21, 2024

nordicjm commented Mar 21, 2024 • edited Loading

fabiobaltieri commented Mar 21, 2024 • edited Loading

joelguittet commented Mar 21, 2024

joelguittet commented Mar 22, 2024

nordicjm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joelguittet commented Apr 7, 2024

joelguittet commented Apr 25, 2024

joelguittet commented Jan 8, 2024 •

edited

Loading

fabiobaltieri left a comment •

edited

Loading

nordicjm commented Mar 21, 2024 •

edited

Loading

fabiobaltieri commented Mar 21, 2024 •

edited

Loading