Add ble support b u585i #67529
Merged
Add ble support b u585i #67529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ABOSTM,
Desvauxm-st,
erwango,
FRASTM,
gautierg-st and
GeorgeCGV
arnout
reviewed
Jan 12, 2024
erwango
reviewed
Jan 12, 2024
erwango
reviewed
Jan 12, 2024
erwango
reviewed
Jan 12, 2024
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
from
aa1f7d4 to
7637f0a
Compare
erwango
requested changes
Jan 15, 2024
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
from
7637f0a to
70250d1
Compare
erwango
requested changes
Jan 15, 2024
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
3 times, most recently
from
739ed25 to
b607082
Compare
erwango
reviewed
Jan 15, 2024
erwango
reviewed
Jan 16, 2024
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
4 times, most recently
from
e5fb830 to
05d12f4
Compare
erwango
requested changes
Jan 19, 2024
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
2 times, most recently
from
c32cf79 to
0c3f657
Compare
javad123javad
requested review from
karstenkoenig,
manuargue,
mmahadevan108 and
dleach02
as code owners
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
from
0c3f657 to
5b7280a
Compare
This patch introduces the Bluetooth Low Energy (BLE) feature to the board. The board utilizes the STM32WB5MMG as the BLE module. However, As there was no BLE controller available for this module. Therefore, a board support package has been added to enable the STM32WB5MMG module to act as a BLE controller. This is achieved by running Zephyr's hci_uart example on the STM32WB5MMG module which enables communication with the main microcontroller over the H:4 HCI transport protocol. So, users must first build the BLE controller for the BLE module and upload it via on board ST-Link,then they can uses Zephyr Bluetooth demos on the development board Note that there was no hardware flow control wiring available on the board, which is why it has been disabled in the both main board and BLE module Device Tree. Signed-off-by: Javad Rahimipetroudi <[email protected]>
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
from
5b7280a to
20fecb6
Compare
erwango
previously approved these changes
Jan 22, 2024
|
@javad123javad Please fix compliance issue |
Sure, As it is approved, what is the proper way to do it? should I rebase to my commit or to the base commit? |
Yep: fix and force-push. Avoid rebase if not required. You'll lost approval, but we should be able to identify change easily and re-approve quickly. |
This commits makes it possible to use the onboard bluetooth module (STM32WB5MMG) with existing zephyr bluetooth samples. Note that there was no hardware flow control wiring available on the board, which is why it has been disabled in the both main board and BLE module Device Tree. As the board doesn't support HW flow control, users must set CONFIG_BT_HCI_ACL_FLOW_CONTROL=n in project files. Signed-off-by: Javad Rahimipetroudi <[email protected]>
javad123javad
force-pushed
the
add_ble_support_b_u585i
branch
from
20fecb6 to
9be46cf
Compare
erwango
approved these changes
Jan 24, 2024
For instance, here what github proposed me to check: https://github.com/zephyrproject-rtos/zephyr/compare/20fecb6bd83305e2c1fbc614cfb333a9f0301944..9be46cfd25e1d23da7b5cd7402a65367d28277e1. Quickly reviewed! |
erwango
approved these changes
Jan 26, 2024
gautierg-st
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the Bluetooth Low Energy (BLE) feature to the board.
The board utilizes the STM32WB5MMG as the BLE module. However, As there
was no BLE controller available for this module. Therefore, a board
support package has been added to enable the STM32WB5MMG module to act as
a BLE controller. This is achieved by running Zephyr's hci_uart example on
the STM32WB5MMG module which enables communication with the main
microcontroller over the H:4 HCI transport protocol. So, users must first
build the BLE controller for the BLE module and upload it via on board
ST-Link,then they can uses Zephyr Bluetooth demos on the development board
Note that there was no hardware flow control wiring available on the
board, which is why it has been disabled in the both main board and BLE
module Device Tree. As the board doesn't support HW flow control, users
must must set CONFIG_BT_HCI_ACL_FLOW_CONTROL=n in project files.