boards: qemu_cortex_m0: minor cleanups #67866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting an extremely low value by default on two boards doesn't seem like the right thing to do. The defaults were added with the v1 logging subsystem in zephyrproject-rtos#8023. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
requested review from
de-nordic,
ioannisg and
stephanosio
as code owners
zephyrbot
requested review from
bbolen,
carlocaione,
galak,
ithinuel,
MaureenHelm,
microbuilder,
povergoing and
SgrrZhf
When running under qemu (for example `qemu_cortex_m0`), the erase value of the flash is 0x00, not 0xFF. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
240120_qemu_m0
branch
from
baabe99 to
627f120
Compare
|
So this is not the right approach for the nRF flash, as it does still erase to 0xFF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't set arbitrary low values for
LOG_BUFFER_SIZEin boards.Correct the
.erase_valueparameter for nRF SoC flash when running in emulation.