fb: cfb: Remove the restriction for not x8 heights fonts #67883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke the rendering of the CFB_FONT_MSB_FIRST font in the previously committed zephyrproject-rtos#53796. I will correct the entire font rendering process to make it easier to remove the restriction that the vertical size of the font must be a multiple of 8. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add testcases for testing basic CFB functions. This tests cannot run in CI because CI environment has no display. Mark these tests as `build_only`. Signed-off-by: TOKITA Hiroshi <[email protected]>
The logic introduced in zephyrproject-rtos#67881 can also handle fonts with heights other than x8. Remove the restriction. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add testcases for 1x1 and 11x13 fonts. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
remove_font_size_restriction
branch
from
d82ad83 to
37cdad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic introduced in #67881 can also handle fonts with heights other than x8.
Remove the restriction.