Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hwmv2: port intel x86 boards #67885

Merged
merged 11 commits into from
Feb 1, 2024
Merged

hwmv2: port intel x86 boards #67885

merged 11 commits into from
Feb 1, 2024

Conversation

golowanow
Copy link
Member

@golowanow golowanow commented Jan 21, 2024 •
edited
Loading

move and convert x86 soc/boards to HWMv2:

  • atom

  • apollo_lake

    • up_squared

  • alder_lake

    • intel_adl_crb
    • intel_adl_rvp
    • up_squared_pro_7000

  • elkhart_lake

    • intel_ehl_crb
    • intel_ehl_crb//sbl

  • raptor_lake

    • intel_rpl_p_crb
    • intel_rpl_s_crb

@golowanow golowanow mentioned this pull request Jan 21, 2024
Closed
@golowanow golowanow requested review from nashif and tejlmand January 21, 2024 18:01
@nashif nashif requested review from nordicjm and jhedberg January 22, 2024 19:23
@golowanow golowanow force-pushed the hwmv2_intel_x86 branch 3 times, most recently from db7c6d5 to ca9884a Compare January 23, 2024 13:31
@golowanow golowanow requested a review from nashif January 24, 2024 08:39
golowanow
golowanow commented Jan 24, 2024
View reviewed changes
soc/v2/ia32/soc.yml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ia32 is put at the top level as generic, please confirm is it ok ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to #68078

@finikorg
Copy link
Collaborator

Should the vendor name be up or aaeon ?

@golowanow
Copy link
Member Author

golowanow commented Jan 24, 2024 •
edited
Loading

Should the vendor name be up or aaeon ?

good question, it is disributed by 'up bridge the gap', Zephyr documentation also points to up-board.org, and at #67682 it is listed as 'up'.

@golowanow
Copy link
Member Author

golowanow commented Jan 24, 2024 •
edited
Loading

SoC: ia32 and lakemont are moved to #68078 to complement qemu_x86 and separate CI issues detected.

@golowanow golowanow marked this pull request as ready for review January 24, 2024 19:28
@golowanow golowanow requested a review from nandojve as a code owner January 25, 2024 16:55
@golowanow golowanow mentioned this pull request Jan 25, 2024
Merged
@golowanow
Copy link
Member Author

CI twister run has no issues after the rebase

@golowanow
Copy link
Member Author

@tejlmand - could you please provide some feedback - is this PR on track with the general v1 to v2 migration principles ?

nordicjm
nordicjm reviewed Jan 30, 2024
View reviewed changes
boards/v2/up/up_squared/doc/index.rst Show resolved Hide resolved
boards/v2/intel/intel_adl/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/v2/up/up_squared_pro_7000/Kconfig.defconfig Outdated Show resolved Hide resolved
soc/v2/intel/elkhart_lake/Kconfig.soc Show resolved Hide resolved
boards/v2/intel/intel_ehl/board.yml Outdated Show resolved Hide resolved
boards/v2/intel/intel_rpl/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/v2/intel/intel_rpl/board.yml Show resolved Hide resolved
tejlmand
tejlmand requested changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor adjustment needed.

Also consider if some of the boards should be using variants as pointed out by @nordicjm

soc/v2/intel/elkhart_lake/Kconfig.soc Show resolved Hide resolved
@golowanow
soc: apollo_lake: move and convert to HWMv2
c49bdac 
Move and convert soc/x86/apollo_lake to HWMv2.

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
boards: x86: up_squared: move and convert to HWMv2
c3c8855 
Move and convert boards/x86/up_squared to HWMv2

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
samples: up_squared: adjust gpio_counter to HWMv2
4d1998c 
Adjust samples/boards/up_squared/gpio_counter to HWMv2 changes
of the up_squared board.

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
soc: alder_lake: move and convert to HWMv2
10477c7 
Move and convert soc/x86/alder_lake to HWMv2

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
boards: x86: intel_adl: move and convert alder_lake boards to HWMv2
300b96e 
Move and convert intel_adl_crb and intel_adl_rvp boards to HWMv2.

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
boards: x86: up_squared_pro_7000: move and convert to HWMv2
4cdfbe2 
Move and convert boards/x86/up_squared_pro_7000 to HWMv2

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
soc: x86: elkhart_lake: move and convert to HWMv2
6be7edd 
Move and convert soc/x86/elkhart_lake ot HWMv2

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
boards: x86: intel_ehl: move and convert elkhart_lake boards to HWMv2
700945e 
Move and convert `intel_ehl_crb` and `intel_ehl_crb_sbl` board
configurations to HWMv2.

`intel_ehl_crb_sbl` is changed to a variant `intel_ehl_crb/elkhart_lake/sbl`

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
soc: x86: raptor_lake: move and convert to HWMv2
f50557f 
Move and convert soc/x86/raptor_lake to HWMv2

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
boards: x86: intel_rpl: move and convert raptor_lake boards to HWMv2
b3d8754 
Move and convert intel_rpl_p_crb and intel_rpl_s_crb boards to HWMv2.

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow
soc: x86: atom: move and convert to HWMv2
b9ca5a9 
Move and convert soc/x86/atom to HWMv2

Signed-off-by: Dmitrii Golovanov <[email protected]>
@nordicjm nordicjm merged commit 5c03689 into zephyrproject-rtos:collab-hwm Feb 1, 2024
23 of 25 checks passed
@golowanow golowanow deleted the hwmv2_intel_x86 branch February 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@tejlmand tejlmand tejlmand approved these changes

@nordicjm nordicjm nordicjm approved these changes

@nashif nashif Awaiting requested review from nashif

@najumon1980 najumon1980 Awaiting requested review from najumon1980

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@finikorg finikorg Awaiting requested review from finikorg

@nandojve nandojve Awaiting requested review from nandojve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@golowanow @finikorg @nashif @jhedberg @tejlmand @nordicjm