Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: http_server: fix URL matching with '?' character in resource #84226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrodgers-witekio
Copy link
Collaborator

Fixes #84198.

If a '?' character is used as part of a wildcard resource, do not treat this as the end of the string when comparing with a path from the HTTP request. Only the path from the HTTP request may be terminated by '?' (in the case of a request with query parameters).

@zephyrbot zephyrbot added area: HTTP HTTP client/server support area: Networking labels Jan 20, 2025
@zephyrbot zephyrbot requested review from jukkar and rlubos January 20, 2025 09:54
Fixes zephyrproject-rtos#84198.

If a '?' character is used as part of a wildcard resource, do not treat
this as the end of the string when comparing with a path from the HTTP
request. Only the path from the HTTP request may be terminated by '?'
(in the case of a request with query parameters).

Signed-off-by: Matt Rodgers <[email protected]>
@mrodgers-witekio mrodgers-witekio force-pushed the http_server_fix_path_compare_wildcard branch from 8122692 to a96e14e Compare January 20, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: HTTP HTTP client/server support area: Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP URL Parsing Fails when CONFIG_HTTP_SERVER_RESOURCE_WILDCARD is enabled and wildcard contains "?"
4 participants