shell: fix unsafe API calls and add configurable autoflush behavior #84290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-uC
added
bug
jakub-uC
force-pushed
the
fix/shell-print-deadlock
branch
from
c6785c0 to
ac27480
Compare
pdgendt
reviewed
Jan 21, 2025
pdgendt
added
backport v3.7-branch
pdgendt
requested changes
Jan 21, 2025
jakub-uC
force-pushed
the
fix/shell-print-deadlock
branch
from
c223c7b to
f1488c3
Compare
|
@pdgendt done |
pdgendt
previously approved these changes
Jan 21, 2025
nordic-krch
previously approved these changes
Jan 21, 2025
kartben
requested changes
Jan 21, 2025
There was a problem hiding this comment.
commit message should not include github references https://docs.zephyrproject.org/latest/contribute/guidelines.html#adding-links
Introduced a new Kconfig option `SHELL_PRINTF_AUTOFLUSH` to allow configuring the autoflush behavior of shell printing functions. Updated `Z_SHELL_FPRINTF_DEFINE` to use the `CONFIG_SHELL_PRINTF_AUTOFLUSH` setting instead of hardcoding the autoflush behavior to `true`. Signed-off-by: Jakub Rzeszutko <[email protected]>
Fixes an issue where the shell API could block indefinitely when called from threads other than the shell's processing thread, especially when the transport (e.g. USB CDC ACM) was unavailable or inactive. Replaced `k_mutex_lock` calls with an indefinite timeout (`K_FOREVER`) by using a fixed timeout (`K_MSEC(SHELL_TX_MTX_TIMEOUT_MS)`) in shell API functions to prevent indefinite blocking. Link: zephyrproject-rtos#84274 Signed-off-by: Jakub Rzeszutko <[email protected]>
jakub-uC
force-pushed
the
fix/shell-print-deadlock
branch
from
f1488c3 to
04fa35e
Compare
|
@kartben Fixed, I missed that new rule |
pdgendt
approved these changes
Jan 22, 2025
henrikbrixandersen
approved these changes
Jan 22, 2025
nordic-krch
approved these changes
Jan 23, 2025
kartben
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the shell API could block indefinitely when called from threads other than the shell's processing thread, especially when the transport (e.g. USB CDC ACM) was unavailable or inactive.
Changes made:
k_mutex_lockcalls with an indefinite timeout (K_FOREVER) by using a fixed timeout (K_MSEC(SHELL_TX_MTX_TIMEOUT_MS)) in shell API functions to prevent indefinite blocking.SHELL_PRINTF_AUTOFLUSHto allow configurable autoflush behavior for shell printing functions.Z_SHELL_FPRINTF_DEFINEto use theCONFIG_SHELL_PRINTF_AUTOFLUSHsetting instead of hardcoding the autoflush behavior totrue.Links: #84274