Fix/nxp shim driver fixes #85285
Open
Fix/nxp shim driver fixes #85285
+149
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Wi-Fi
zephyrbot
requested review from
butok,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
jukkar,
kartben,
Kludentwo,
krish2718,
MaochenWang1,
mmahadevan108,
nashif and
rlubos
MaochenWang1
reviewed
Feb 6, 2025
| @@ -63,7 +62,7 @@ CONFIG_NET_IPV6_FRAGMENT_MAX_COUNT=3 | |||
| CONFIG_NET_IPV6_FRAGMENT_MAX_PKT=8 | |||
| CONFIG_NET_IPV6_FRAGMENT_TIMEOUT=3 | |||
| CONFIG_NET_MAX_CONN=10 | |||
| CONFIG_NET_DHCPV4_SERVER_ICMP_PROBE_TIMEOUT=100 | |||
| CONFIG_NET_MAX_CONN=10 | |||
There was a problem hiding this comment.
duplicate CONFIG_NET_MAX_CONN
fengming-ye
force-pushed
the
fix/nxp_shim_driver_fixes
branch
from
83c3b04 to
447e4a0
Compare
MaochenWang1
previously approved these changes
Feb 7, 2025
jukkar
reviewed
Feb 7, 2025
drivers/wifi/nxp/nxp_wifi_drv.c
Outdated
| #ifdef CONFIG_NXP_WIFI_GET_LOG | ||
| static int nxp_wifi_get_detail_stats(int bss_type, wlan_pkt_stats_t *stats) | ||
| { | ||
| int ret = -1; |
There was a problem hiding this comment.
If you set here int ret = -ENODEV; then the last else branch can be omitted. Now setting the ret to -1 is useless as the else branch sets the value anyway.
drivers/wifi/nxp/nxp_wifi_drv.c
Outdated
| static int nxp_wifi_stats(const struct device *dev, struct net_stats_wifi *stats) | ||
| { | ||
| struct interface *if_handle = (struct interface *)dev->data; | ||
| #ifdef CONFIG_NXP_WIFI_GET_LOG | ||
| int ret = -1; |
There was a problem hiding this comment.
No need to set the value to -1 as you assign value to it almost immediately. Same thing with wifi_stats which gets its value set also few lines below.
drivers/wifi/nxp/nxp_wifi_drv.c
Outdated
Comment on lines
1267
to
1268
| int ret = -1; | ||
| wlan_pkt_stats_t *wifi_stats = NULL; |
There was a problem hiding this comment.
Same here, both of these get their value set few lines below so no need to do it here.
There was a problem hiding this comment.
updated as all above comments
Add support for wifi overrun count, beacon received and beacon missed count. Add support for wifi statistics clear. Signed-off-by: Fengming Ye <[email protected]>
For embedded supplicant soft AP mode, add beacon period, DTIM period and BTWT support status fields. Signed-off-by: Fengming Ye <[email protected]>
Decouple dependency of CONFIG_NXP_WIFI_SOFTAP_SUPPORT. Add wifi defconfig to set default kconfig options when soft AP enabled. Signed-off-by: Fengming Ye <[email protected]>
Add correct macro guard for soft AP only code. Signed-off-by: Fengming Ye <[email protected]>
fengming-ye
force-pushed
the
fix/nxp_shim_driver_fixes
branch
from
447e4a0 to
5ed4f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
83c3b04
drivers: wifi: nxp: add support for soft AP disabled case
6d2e649
wifi: kconfig: decouple dependency of soft AP
63b544d
drivers: wifi: nxp: add soft AP status for some fields
f552084
drivers: wifi: nxp: add wifi statistics support