samples: display: lvgl: test with XIAO round display #85477
Conversation
zephyrbot
requested review from
danieldegrasse,
jfischer-no,
kartben and
nashif
| samples.subsys.display.lvgl.seeed_xiao_round_display: | ||
| min_flash: 320 | ||
| min_ram: 64 | ||
| depends_on: |
There was a problem hiding this comment.
Please remove these non-standard tags from here, as well as from boards yaml files. Compatible boards could be added to platform_allow list instead.
There was a problem hiding this comment.
@JarmouniA what do you mean by non-standard?
There was a problem hiding this comment.
Sorry non-standard is not really a useful description, I meant to say very platform-specific. I don't think it would be good to start adding twister tags for every kind of boards, it would be very confusing... but that's just my opinion.
There was a problem hiding this comment.
Introduced xiao_{adc,i2c,spi,serial,gpio} are supposed to map what we have for arduino_{i2c,spi,serial,gpio} already. The nice thing about it is that all boards that have the same header are ready to be tested without specifying each board manually inside platform_allow.
There was a problem hiding this comment.
Arduino headers are a universal thing that can be found on a lot of dev board, that's why it has its own tags.
There was a problem hiding this comment.
Agree. XIAO header is available on about 15 boards (just some of them are supported in Zephyr so far), with many shields available as well. Number of those is obviously much smaller than Arduino compatible ones. Do you think that it is not worth adding supported tags for XIAO, similar as for Arduino?
There was a problem hiding this comment.
Okey I guess it's fine.
| - xiao_i2c | ||
| - xiao_spi | ||
| tags: | ||
| - samples |
There was a problem hiding this comment.
If you could move these tags to a common section at the beginning of the file, that would be nice.
There was a problem hiding this comment.
Each test has a bit different set of tags, we don't use the same tags there for each test.
There was a problem hiding this comment.
samples display gui lvgl are common to all test cases, shield can be left in test cases that need it.
There was a problem hiding this comment.
Deduplicated tags (as suggested) as well as modules (it was always lvgl)`.
mniestroj
force-pushed
the
lvgl-add-seeed-xiao-round-display
branch
from
62dd9d2 to
c73b8b6
Compare
Mark interfaces on XIAO header that are supported by each board. This allows to filter by them (with depends_on) when running twister. Signed-off-by: Marcin Niestroj <[email protected]>
When tested with xiao_esp32s3 + seeed_xiao_round_display main stack is occupied with 3504 bytes (checked with 'kernel thread stacks' command). Increase main stack size from 2k to 4k in order to make this sample work at runtime. Signed-off-by: Marcin Niestroj <[email protected]>
Move 'tags' and 'modules' into common section in samples.yaml, so test definitions are deduplicated a bit. Signed-off-by: Marcin Niestroj <[email protected]>
Use 'sample.' in the sample definition, in order to follow Zephyr convention. Signed-off-by: Marcin Niestroj <[email protected]>
This shield is compatible with all XIAO boards. Tested with 2 of them: * xiao_ble * xiao_esp32s3 Extend sample.yaml for integration testing with both, so there is coverage across two very distinct SoC vendors and architectures. Signed-off-by: Marcin Niestroj <[email protected]>
| - gui | ||
| - lvgl | ||
| - samples | ||
| - shield |
There was a problem hiding this comment.
shield tag is not common to all test cases, there are boards that come with built-in displays.
There was a problem hiding this comment.
Yes, noticed the same and just fixed that.
mniestroj
force-pushed
the
lvgl-add-seeed-xiao-round-display
branch
from
c73b8b6 to
c149d0c
Compare
"XIAO round display" shield is compatible with most XIAO boards and is very nice platform for using
as round smartwatch-like display. Add tests of LVGL sample based on selected XIAO boards in order to
make sure this shield definition remains valid.