Build all C# solutions in CI (#292)

.github/workflows/ci.yml

@@ -36,10 +36,6 @@ jobs:
       - name: Windows Environment
         if: runner.os == 'Windows'
         run: |
-          echo "Platform=x64" >> $env:GITHUB_ENV
-          echo "Configuration=Release" >> $env:GITHUB_ENV
-          echo "IceHome=${{ github.workspace }}\ice" >> $env:GITHUB_ENV
-
           # We need to replace \ with / in the path, specifically for Gradle
           $iceHome = "${{ github.workspace }}/ice"
           $iceHome = $iceHome.Replace("\", "/")
@@ -49,7 +45,6 @@ jobs:
         if: runner.os != 'Windows'
         run: |
           echo "ICE_HOME=${{ github.workspace }}/ice" >> $GITHUB_ENV
-          echo "IceHome=${{ github.workspace }}/ice" >> $GITHUB_ENV
 
       - name: Checkout Ice
         uses: actions/checkout@v4
@@ -66,12 +61,12 @@ jobs:
         timeout-minutes: 60
         with:
           working_directory: ice
-          build_flags: ${{ runner.os == 'Windows' && '/t:BuildDist' || 'srcs' }}
+          build_flags: ${{ runner.os == 'Windows' && '/t:BuildDist /p:Configuration=Release /p:Platform=x64' || 'srcs' }}
 
       - name: Publish C# NuGet Packages
         timeout-minutes: 5
         working-directory: ice/csharp/msbuild
-        run: dotnet msbuild ice.proj /t:Publish
+        run: dotnet msbuild ice.proj /t:Publish /p:Configuration=Release /p:Platform=x64
 
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -91,8 +86,8 @@ jobs:
 
           find . -name CMakeLists.txt -type f | while IFS= read -r file; do
             dir=$(dirname "$file");
-            cmake -B "$dir/build" -S "$dir" -DIce_DEBUG=ON
-            cmake --build "$dir/build" --config Release
+            cmake -B "$dir/build" -S "$dir" -DIce_DEBUG=ON -DCMAKE_BUILD_TYPE=Release
+            cmake --build "$dir/build"
           done
         if: runner.os != 'Windows'
 
@@ -113,10 +108,28 @@ jobs:
       - name: Build C# Demos
         timeout-minutes: 20
         working-directory: ice-demos/csharp
-        run: dotnet build
+        run: |
+          find . -name '*.sln' -type f | while IFS= read -r file; do
+            dotnet build "$file"
+          done
+        if: runner.os != 'Windows'
+
+      - name: Build C# Demos
+        timeout-minutes: 20
+        working-directory: ice-demos/csharp
+        run: |
+          Get-ChildItem -Recurse -Filter *.sln | ForEach-Object {
+            dotnet build $_.FullName
+          }
+        if: runner.os == 'Windows'
 
       - name: Run .NET format
-        run: dotnet format --verify-no-changes "./ice-demos/csharp/C# NET demos.sln"
+        working-directory: ice-demos/csharp
+        run: |
+          find . -name '*.sln' -type f | while IFS= read -r file; do
+            dotnet format --verify-no-changes "$file"
+          done
+        shell: bash
         if: runner.os == 'Linux'
 
       - name: Build Java Demos

csharp/Ice/Callback/Client/MockAlarmClock.cs

@@ -16,6 +16,7 @@ internal class MockAlarmClock : AlarmClockDisp_
 
     private bool _needMoreTime = true;
 
+    /// <inheritdoc/>
     // Implements the abstract method Ring from the AlarmClockDisp_ class generated by the Slice compiler.
     public override ButtonPressed Ring(string message, Ice.Current current)
     {

csharp/Ice/Callback/Server/SimpleWakeUpService.cs

@@ -7,6 +7,7 @@ namespace Server;
 /// <summary>SimpleWakeUpService is an Ice servant that implements Slice interface WakeUpService.</summary>
 internal class SimpleWakeUpService : WakeUpServiceDisp_
 {
+    /// <inheritdoc/>
     // Implements the abstract method WakeMeUp from the WakeUpServiceDisp_ class generated by the Slice compiler.
     public override void WakeMeUp(AlarmClockPrx? alarmClock, long timeStamp, Ice.Current current)
     {

csharp/Ice/Config/Server/Chatbot.cs

@@ -7,6 +7,7 @@ namespace Server;
 /// <summary>Chatbot is an Ice servant that implements Slice interface Greeter.</summary>
 internal class Chatbot : GreeterDisp_
 {
+    /// <inheritdoc/>
     // Implements the abstract method Greet from the GreeterDisp_ class generated by the Slice compiler.
     // This variant is the synchronous implementation.
     public override string Greet(string name, Ice.Current current)

csharp/Ice/Filesystem/Server/MDirectory.cs

@@ -19,6 +19,6 @@ internal class MDirectory : Filesystem.DirectoryDisp_
     internal MDirectory(string name) => _name = name;
 
     /// <summary>Adds a node to this directory.</summary>
-    /// <param name="child">The node proxy to add</param>
+    /// <param name="child">The node proxy to add.</param>
     internal void AddChild(Filesystem.NodePrx child) => _contents.Add(child);
 }

csharp/Ice/Forwarder/ForwardingServer/Forwarder.cs

@@ -11,6 +11,7 @@ internal class Forwarder : Ice.Object
     // A template for the target proxy.
     private readonly Ice.ObjectPrx _targetTemplate;
 
+    /// <inheritdoc/>
     // Implements abstract method dispatchAsync defined on Ice.Object.
     public async ValueTask<OutgoingResponse> dispatchAsync(IncomingRequest request)
     {

csharp/Ice/Forwarder/Server/Chatbot.cs

@@ -7,6 +7,7 @@ namespace Server;
 /// <summary>Chatbot is an Ice servant that implements Slice interface Greeter.</summary>
 internal class Chatbot : GreeterDisp_
 {
+    /// <inheritdoc/>
     // Implements the abstract method Greet from the GreeterDisp_ class generated by the Slice compiler.
     // This variant is the synchronous implementation.
     public override string Greet(string name, Ice.Current current)

csharp/Ice/Greeter/Server/Chatbot.cs

@@ -7,6 +7,7 @@ namespace Server;
 /// <summary>Chatbot is an Ice servant that implements Slice interface Greeter.</summary>
 internal class Chatbot : GreeterDisp_
 {
+    /// <inheritdoc/>
     // Implements the abstract method Greet from the GreeterDisp_ class generated by the Slice compiler.
     // This variant is the synchronous implementation.
     public override string Greet(string name, Ice.Current current)

csharp/Ice/Greeter/ServerAMD/Chatbot.cs

@@ -7,6 +7,7 @@ namespace ServerAMD;
 /// <summary>Chatbot is an Ice servant that implements Slice interface Greeter.</summary>
 internal class Chatbot : GreeterDisp_
 {
+    /// <inheritdoc/>
     // Implements the abstract method GreetAsync from the GreeterDisp_ class generated by the Slice compiler.
     // This version uses the Asynchronous Method Dispatch (AMD) variant.
     public override async Task<string> GreetAsync(string name, Ice.Current current)