New Middleware demo in C# #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 13, 2025
| // ObjectNotExistException is one of the 6 Ice local exceptions that Ice transmits "over the wire". | ||
| // It usually means "no servant was found for this identity". Here, we reuse it to indicate an authorization | ||
| // failure without leaking information to the client. | ||
| throw new Ice.ObjectNotExistException(); |
There was a problem hiding this comment.
The most debatable aspect to this demo. There is no perfect solution with the Ice protocol since "system exceptions" are not extensible.
Defining a new user exception, like in the existing interceptor demo, is not good as it pollutes all Slice operation signatures.
UnknownException works but triggers by default a log from the logger middleware (Ice.Warn.Dispatch=1 by default). ONE or perhaps OpNE sounds like the best option.
pepone
approved these changes
Feb 13, 2025
externl
approved these changes
Feb 13, 2025
Co-authored-by: Joe George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new middleware demo in C#. It will replace the interceptor demo.