Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cmake support for nightly nugets #307

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Conversation

externl
Copy link
Member

@externl externl commented Feb 19, 2025

No description provided.

@externl externl changed the title Add Cmake support for nightly nugets: Add Cmake support for nightly nugets Feb 19, 2025
@externl externl marked this pull request as ready for review February 19, 2025 19:09
@externl externl requested a review from pepone February 19, 2025 19:09
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we could move the dependency specification into a nuget.config file.

endif()

if(WIN32)
list(APPEND ice_bin_path_suffixes "cpp/bin/${Ice_ARCHITECTURE}/Release" "cpp/bin/${Ice_ARCHITECTURE}/Debug")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't there separate suffixes for Release and Debug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really for finding this binary.

@externl externl merged commit f0ebbe8 into zeroc-ice:main Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants