Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lodash import for esm builds #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdirks4
Copy link

@cdirks4 cdirks4 commented Jun 8, 2024

Allows package to be built, previously would receive.

waas % node dist/esm/index.js

node:internal/process/esm_loader:34
      internalBinding('errors').triggerUncaughtException(
                                ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/waas/node_modules/lodash/uniq' imported from //waas/dist/esm/index.js
Did you mean to import "lodash/uniq.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:263:11)
    at moduleResolve (node:internal/modules/esm/resolve:908:10)
    at defaultResolve (node:internal/modules/esm/resolve:1131:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: '/waas/node_modules/lodash/uniq'
}

Node.js v21.6.2

@tanishbaansal
Copy link

can we please merge this out ?

@cdirks4
Copy link
Author

cdirks4 commented Jan 30, 2025

can we please merge this out ?

I would avoid this package, I informed them about this pr months a go in discord as well, it is no longer maintained, I would be wary relying on any of the packages from this org in your code as it seems they remove support without notice.
I would suggest https://github.com/pimlicolabs/permissionless.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants