Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query bug when fetching filtered entity lists #47

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

justinian
Copy link
Contributor

In librg_world_fetch_chunkarray and librg_world_fetch_ownerarray, only the first buffer_limit of the world's entities were ever being checked, even if no matching entities had yet been added to the list. This meant that even if you know there are a small number of entites owned by a given owner, you have to pass a big enough array to hold the whole world to be sure to find them.

In librg_world_fetch_chunkarray and librg_world_fetch_ownerarray, only
the first buffer_limit of the world's entities were ever being checked,
even if no matching entities had yet been added to the list. This meant
that even if you know there are a small number of entites owned by a
given owner, you have to pass a big enough array to hold the whole world
to be sure to find them.
@inlife
Copy link
Member

inlife commented Jan 20, 2025

Good catch. Since we then returned a suggested increase in the buffer size, all cases are covered.

Thanks for the fix! 🎉

@inlife inlife merged commit d0b7a59 into zpl-c:master Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants