Re-vendor gtest (@ 1.13.0) #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submodule ended up causing a bunch of issues because it's not included in zip/tarball downloads from GitHub and isn't cloned by default, which led to build errors for things wanting to consume string-theory as a dependency (since the CMake project here expects gtest to exist and doesn't gracefully handle the case where it does not). Since we're essentially frozen at an old tag of gtest anyways, it doesn't seem that bad to just go back to vendoring it like we used to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule ended up causing a bunch of issues because it's not included in zip/tarball downloads from GitHub and isn't cloned by default, which led to build errors for things wanting to consume string-theory as a dependency (since the CMake project here expects gtest to exist and doesn't gracefully handle the case where it does not).
Since we're essentially frozen at an old tag of gtest anyways, it doesn't seem that bad to just go back to vendoring it like we used to.
Closes #40.