Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

nicholasyang2022 · 2024-05-16T07:28:52Z

This pull request implements migrating corosync.conf from corosync 2 to corosync 3, including:

migrate deprecated transport udpu and udp to knet
replace removed feature RRP with knet multilink
if crypto_hash is set to sha1, which is the default value in corosync 2, upgrades it to the new default in corosync 3, sha256.

Use Cases

Check When cluster services are running

> sudo crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[FAIL] Cluster services are running
       * corosync
       * pacemaker
[INFO] Checking used corosync features...

------ cib ------
[INFO] Checking used resource agents...

------ ha-2-2 ------
[FAIL] Cluster services are running
       * corosync
       * pacemaker

****** summary ******
[FAIL] The pacemaker cluster stack can not migrate to SLES 16.

Check When All Green for Migration

> sudo crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[INFO] Checking used corosync features...
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

------ cib ------
[INFO] Checking used resource agents...

------ ha-2-2 ------
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

****** summary ******
[INFO] Please run "crm cluster health sles16 --fix" on on any one of above nodes.
[PASS] This cluster is good to migrate to SLES 16.

Check When Already Migrated

> sudo crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[INFO] Checking used corosync features...

------ cib ------
[INFO] Checking used resource agents...

------ ha-2-2 ------

****** summary ******
[INFO] This cluster works on SLES 16. No migration is needed.

Run Migration

> sudo crm cluster health sles16 --fix
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[INFO] Checking used corosync features...
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

------ cib ------
[INFO] Checking used resource agents...

------ ha-2-2 ------
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

INFO: Starting migration...
INFO: Migrating corosync configuration...
INFO: Upgrade totem.transport to knet.
INFO: Upgrade totem.crypto_hash from "sha1" to "sha256".
INFO: Finish migrating corosync configuration.
INFO: Finished migration.

Try to Run Migration When Already Migrated

> sudo crm cluster health sles16 --fix
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[INFO] Checking used corosync features...

------ cib ------
[INFO] Checking used resource agents...

------ ha-2-2 ------

INFO: This cluster works on SLES 16. No migration is needed.

codecov · 2024-05-16T07:50:04Z

Codecov Report

Attention: Patch coverage is 73.88664% with 129 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (87655e0) to head (a5c18a6).

Files with missing lines	Patch %	Lines
crmsh/migration.py	72.51%	119 Missing ⚠️
crmsh/ui_cluster.py	73.68%	10 Missing ⚠️

Additional details and impacted files

Flag	Coverage Δ
integration	`53.98% <73.48%> (+0.37%)`	⬆️
unit	`52.56% <22.87%> (-0.52%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
crmsh/cibquery.py	`100.00% <100.00%> (ø)`
crmsh/corosync.py	`87.64% <100.00%> (ø)`
crmsh/prun/runner.py	`64.86% <100.00%> (+0.97%)`	⬆️
crmsh/sh.py	`92.50% <ø> (+0.41%)`	⬆️
crmsh/xmlutil.py	`69.24% <100.00%> (+0.03%)`	⬆️
crmsh/ui_cluster.py	`74.52% <73.68%> (-0.63%)`	⬇️
crmsh/migration.py	`72.51% <72.51%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liangxin1300 · 2025-01-03T08:06:32Z

In

# crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[FAIL] Pacemaker version not supported
       Supported version: 3 <= Pacemaker
       Actual version:    Pacemaker == 2.1.9

Supported version: 3 <= Pacemaker better changed similar as Supported version: Pacemaker >= 3

liangxin1300 · 2025-01-03T08:23:52Z

# crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[FAIL] Pacemaker version not supported
       Supported version: 3 <= Pacemaker
       Actual version:    Pacemaker == 2.1.9
[INFO] Checking service status...
[FAIL] Cluster services are running
       * corosync
       * pacemaker
[INFO] Checking used corosync features...

------ alp-3 ------



------ alp-2 ------

No output for remote nodes

zzhou1 · 2025-01-06T06:05:06Z

[FAIL] Cluster services are running
* corosync
* pacemaker

FAIL as the fatal error sounds too strong to me.

No matter it is corosync2 or corosync3 environment, nothing wrong to run crm cluster health sles16 no matter the cluster is running or not.

…205925)

nicholasyang2022 · 2025-02-19T05:35:47Z

Keep the format @ for each check scope header

Then you will get:

------ corosync @ ha-2-2 ------
[FAIL] Cluster services are running
       * corosync
       * pacemaker

…efault

so that it can run in a seperated thread

…8252)

…808) (cherry picked from commit 534b138)

…11808) (cherry picked from commit dc3a0c7)

(cherry picked from commit 0ecf1c6)

(cherry picked from commit d905539)

(cherry picked from commit 8cf8ef3)

(cherry picked from commit 3264f0d)

(cherry picked from commit e656662)

…c#PED-11808) (cherry picked from commit 72cd46f)

(cherry picked from commit 54def35)

…jsc#PED-11808) (cherry picked from commit 7bf54e9)

(cherry picked from commit 84143c4)

…PED-11808) should use recursive queries (cherry picked from commit 4b7e42d)

…ilesystem_with_fstype (cherry picked from commit 48aca45)

(cherry picked from commit 1e48317)

(cherry picked from commit 97fa52b)

as it is not a hard requirement to upgrade pacemaker 2 to 3.

…252)

…ed with `--fix` (jsc#PED-8252)

…jsc#PED-8252) * should not run the migration if already migrated * should not tell users to run `crm cluster health sles16 --fix` if already migrated

nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from 3c620cf to 2d4c6db Compare May 27, 2024 08:05

nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from fdcdc65 to c6cd605 Compare October 23, 2024 03:52

nicholasyang2022 force-pushed the ped-8252-20240516 branch 3 times, most recently from 04ea10f to 69020cc Compare November 1, 2024 04:21

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 69020cc to ab808d1 Compare December 13, 2024 08:00

nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from fa10732 to 68bd445 Compare January 2, 2025 09:14

liangxin1300 mentioned this pull request Jan 3, 2025

[crmsh-4.6] Dev: pre-migration: implement pre-migration checks for SLES 16 (jsc#PED-11808) #1629

Merged

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 68bd445 to 389d007 Compare January 6, 2025 04:54

nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from 486020b to 16cd739 Compare January 23, 2025 07:31

nicholasyang2022 force-pushed the ped-8252-20240516 branch 6 times, most recently from 9e1b95b to 38d9896 Compare February 13, 2025 03:18

Fix: corosync: use os.env instead of os.getenv for consistency (bsc#1…

0163979

…205925)

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 6147124 to 19ce3fc Compare February 19, 2025 05:35

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 19ce3fc to 93a768f Compare February 19, 2025 08:41

nicholasyang2022 added 25 commits February 19, 2025 17:34

Dev: migration: implement multicast to knet migration (jsc#PED-8252)

e332451

Dev: profiles: set default crypto_hash to sha256 to follow corosync d…

5eef6dd

…efault

Dev: ui_cluster: add 'crm cluster health sles [--fix]' (jsc#PED-8252)

ca866e4

Dev: prun: create event loop manually

70c02d2

so that it can run in a seperated thread

Dev: migration: run checks on remote nodes (jsc#PED-8252)

15959c3

Dev: migration: copy migrated corosync.conf to remote nodes (jsc#PED-…

6381a7e

…8252)

Dev: pre-migration: add checks for used corosync features (jsc#PED-11…

ff061e9

…808) (cherry picked from commit 534b138)

Dev: pre-migration: check SAPHanaSR Classic resource agents (jsc#PED-…

8a28b6f

…11808) (cherry picked from commit dc3a0c7)

Dev: pre-migration: check removed resource agents (jsc#PED-11808)

bfa773a

(cherry picked from commit 0ecf1c6)

Dev: pre-migration: check removed fence agents (jsc#PED-11808)

cfc0733

(cherry picked from commit d905539)

Dev: pre-migration: check if ocfs2 is used (jsc#PED-11808)

22b840f

(cherry picked from commit 8cf8ef3)

Dev: add pre-migration checks for pacemaker version (jsc#PED-11808)

faf4e98

(cherry picked from commit 3264f0d)

Dev: pre-migration: do not colorize hostname header (jsc#PED-11808)

a6089c9

(cherry picked from commit e656662)

Dev: pre-migration: add completer for 'crm cluster health sles16' (js…

cf6b0e5

…c#PED-11808) (cherry picked from commit 72cd46f)

Fix: ui_cluster: fix do_health usage output

8b66a54

(cherry picked from commit 54def35)

Dev: pre-migration: add message about removing stonith:external/sbd (…

c7aa209

…jsc#PED-11808) (cherry picked from commit 7bf54e9)

Doc: ui_cluster: add document for crm cluster health hawk2|sles16

6302b31

(cherry picked from commit 84143c4)

Fix: cibquery: grouped primitives is missing from query results (jsc#…

911c188

…PED-11808) should use recursive queries (cherry picked from commit 4b7e42d)

Refactor: cibquery: has_primitive_filesystem_ocfs2 to has_primitive_f…

ca818e6

…ilesystem_with_fstype (cherry picked from commit 48aca45)

Dev: pre-migration: add summary section to output (jsc#PED-11808)

74d229b

(cherry picked from commit 1e48317)

Dev: migration: refine message wording (jsc#PED-11808)

6ba6d12

(cherry picked from commit 97fa52b)

Dev: migration: do not check pacemaker version (jsc#PED-8252)

7c9c4f5

as it is not a hard requirement to upgrade pacemaker 2 to 3.

Dev: behave: add functional tests for pre-migration checks (jsc#PED-8…

8729183

…252)

Fix: migration: should not show pre-migration check summary when call…

b96f625

…ed with `--fix` (jsc#PED-8252)

Dev: migration: check if the cluster is already migrated to SLES 16 (…

a5c18a6

…jsc#PED-8252) * should not run the migration if already migrated * should not tell users to run `crm cluster health sles16 --fix` if already migrated

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 93a768f to a5c18a6 Compare February 19, 2025 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

nicholasyang2022 commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading

liangxin1300 commented Jan 3, 2025

liangxin1300 commented Jan 3, 2025

zzhou1 commented Jan 6, 2025

nicholasyang2022 commented Feb 19, 2025

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Are you sure you want to change the base?

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Conversation

nicholasyang2022 commented May 16, 2024 • edited Loading

Use Cases

Check When cluster services are running

Check When All Green for Migration

Check When Already Migrated

Run Migration

Try to Run Migration When Already Migrated

codecov bot commented May 16, 2024 • edited Loading

Codecov Report

liangxin1300 commented Jan 3, 2025

liangxin1300 commented Jan 3, 2025

zzhou1 commented Jan 6, 2025

nicholasyang2022 commented Feb 19, 2025

nicholasyang2022 commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading