Improve configure schema command
#1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhou1
reviewed
Feb 14, 2025
doc/crm.8.adoc
Outdated
|
|
||
| Usage: | ||
| ............... | ||
| schema [<schema>] | ||
| ............... | ||
| Example: | ||
| ............... | ||
| schema pacemaker-1.1 | ||
| # To get the current schema version |
There was a problem hiding this comment.
Suggested change
| # To get the current schema version | |
| # To get the schema version of the current CIB, or the latest version if no cluster configured yet |
BTW, sounds currently crm configure schema only supports the running cluster. It reports call trace otherwise.
doc/crm.8.adoc
Outdated
| several, depending on version. At least the following schemas are | ||
| accepted by `crmsh`: | ||
| several, depending on version. You can see all supported schemas by | ||
| input +Tab+ after `crm configure schema`. |
There was a problem hiding this comment.
Suggested change
| input +Tab+ after `crm configure schema`. | |
| typing +<TAB><TAB>+ after `crm configure schema`. |
…nfigure schema` Also return False if schema is not supported.
liangxin1300
force-pushed
the
20250214_schema_improve
branch
2 times, most recently
from
459a314 to
9a3c42c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
liangxin1300
force-pushed
the
20250214_schema_improve
branch
from
9a3c42c to
77281bc
Compare
zzhou1
reviewed
Feb 18, 2025
|
|
||
| Usage: | ||
| ............... | ||
| schema [<schema>] | ||
| ............... | ||
| Example: | ||
| ............... | ||
| schema pacemaker-1.1 | ||
| # To get the schema version of the current CIB, or the latest version if no cluster configured yet | ||
| schema |
There was a problem hiding this comment.
Suggested change
| schema | |
| schema | |
| # To get the schema version of the current CIB, or the latest version if no cluster configured yet | ||
| schema | ||
| # To set the new schema version | ||
| schema pacemaker-4.0 |
There was a problem hiding this comment.
Suggested change
| schema pacemaker-4.0 | |
| schema pacemaker-4.0 | |
doc/crm.8.adoc
Outdated
| * +pacemaker-2.0+ | ||
|
|
||
| Use this command to display or switch to another RNG schema. | ||
| Note that it is highly recommended to use the latest schema version. | ||
|
|
||
| Usage: | ||
| ............... | ||
| schema [<schema>] |
There was a problem hiding this comment.
Suggested change
| schema [<schema>] | |
| schema [<pacemaker-schema_version>] |
| # To set the new schema version | ||
| schema pacemaker-4.0 | ||
| # Then need to run `commit` to make the change effective | ||
| # if it's on interactive mode |
There was a problem hiding this comment.
Suggested change
| # if it's on interactive mode | |
| # if it's on interactive mode | |
| commit |
liangxin1300
force-pushed
the
20250214_schema_improve
branch
from
77281bc to
9b1bfe5
Compare
zzhou1
approved these changes
Feb 18, 2025
liangxin1300
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure schemaconfigure schemacommand