Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: ✏️ Add Send Message Headers to the Error Message #212

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

psychology50
Copy link
Member

작업 이유

When a client's message is rejected for some reason, the client cannot handle the issue effectively.
For example, if the client receives an "unauthenticated" error after sending a chat message, it must resend the message to the server.
However, since the client cannot identify which message failed, we need to include a message identifier.


작업 사항

  • When a business error occurs, the server sends an error message that includes the message's headers.
  • If the client adds the x-message-id field to the header, they will be able to identify the specific message.

리뷰어가 중점적으로 확인해야 하는 부분

  • Is the exception handling implemented correctly?

발견한 이슈

  • When a @Validated error occurs, it isn't handled by HttpMessageNotReadableException.class; instead, it is caught by Exception.class
  • After converting PreAuthorizeAspect from Java to Kotlin, it throws a joinPoint.proceed() cannot null error.

@psychology50 psychology50 added the fix 기능 수정 label Dec 31, 2024
@psychology50 psychology50 self-assigned this Dec 31, 2024
@psychology50 psychology50 merged commit 6cb496d into dev Dec 31, 2024
1 check passed
@psychology50 psychology50 deleted the feat/PW-659-message-id-header-in-error-res branch December 31, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 기능 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant