[Chromium] Implement DateTime Picker #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Feb 20, 2024
There was a problem hiding this comment.
I tested it and I could get easily it to crash. Seems easy to fix though
13:31:52.198 27412-27412 System.err W java.lang.NullPointerException: Attempt to invoke interface method 'com.igalia.wolvic.browser.api.WResult com.igalia.wolvic.browser.api.WSession$PromptDelegate.onDateTimePrompt(com.igalia.wolvic.browser.api.WSession, com.igalia.wolvic.browser.api.WSession$PromptDelegate$DateTimePrompt)' on a null object reference
13:31:52.198 27412-27412 W at com.igalia.wolvic.browser.api.impl.PromptDelegateImpl$DateTimeChooserBridge.showDialog(PromptDelegateImpl.java:597)
13:31:52.198 27412-27412 W at org.chromium.content.browser.input.DateTimeChooserAndroid.showDialog(DateTimeChooserAndroid.java:70)
13:31:52.198 27412-27412 W at org.chromium.content.browser.input.DateTimeChooserAndroid.createDateTimeChooser(DateTimeChooserAndroid.java:93)
13:31:52.198 27412-27412 W at android.os.MessageQueue.nativePollOnce(Native Method)
13:31:52.198 27412-27412 W at android.os.MessageQueue.next(MessageQueue.java:335)
13:31:52.198 27412-27412 W at android.os.Looper.loopOnce(Looper.java:167)
13:31:52.198 27412-27412 W at android.os.Looper.loop(Looper.java:304)
13:31:52.198 27412-27412 W at android.app.ActivityThread.main(ActivityThread.java:7918)
13:31:52.198 27412-27412 W at java.lang.reflect.Method.invoke(Native Method)
13:31:52.198 27412-27412 W at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
13:31:52.198 27412-27412 W at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1010)
Thanks for checking. It could be easy to fix this but I'd like to understand why the delegate is the null object. sorry but I couldn't reproduce it. Maybe I'm testing within some pattern only. Could you let me know how to reproduce it? |
I think it was just going back but not really sure. In any case we should add null checks to the delegates because the session might have freed them by the time chromium calls these methods |
Thanks for sharing. I've added the NullPointerException to prevent the access of null delegate. I will patch the safe code for other implementations at this file in a separate patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.