Add a new Sync button in the tabs bar #1718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to receive tabs through the FxA SendTabTo service we need to poll the API; the new button will perform this action. Ideally, we should be able to observe events from the FxA push service, but for now we need to depend on user intervention to ask the server for new tabs.
javifernandez
force-pushed
the
sync-from-new-tabs-bar
branch
from
d5a41c0 to
b34c188
Compare
felipeerias
added a commit
that referenced
this pull request
Jan 27, 2025
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
|
This is a good idea, but I think that the implementation can be a bit simpler. We can just keep a reference to the I have an alternative here: #1722 |
felipeerias
added a commit
that referenced
this pull request
Jan 27, 2025
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
felipeerias
added a commit
that referenced
this pull request
Jan 27, 2025
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
javifernandez
requested review from
svillar and
felipeerias
and removed request for
svillar
felipeerias
added a commit
that referenced
this pull request
Jan 28, 2025
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
felipeerias
added a commit
that referenced
this pull request
Jan 28, 2025
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
svillar
pushed a commit
that referenced
this pull request
Jan 28, 2025
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to receive tabs through the FxA SendTabTo service we need to poll the API; the new button will perform this action.
Ideally, we should be able to observe events from the FxA push service, but for now we need to depend on user intervention to ask the server for new tabs.