Add 2 new properties for fuzzy positions #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently not straight forward to model possible positions for OneOfPosition, see OBF#37. The new property possiblePositions makes it simpler. The second new property for FuzzyPosition, probability, cover cases as those of PTMs in IntAct where a probability is assigned to a fuzzy position.
JervenBolleman
requested changes
Dec 13, 2018
|
|
||
| :possiblePosition | ||
| rdf:type owl:ObjectProperty ; | ||
| rdfs:comment "One of the possible positions listed for a OneOfPosition element."^^xsd:string ; ; |
There was a problem hiding this comment.
This line ends with ; ; instead of just one. could lead to issues.
| rdfs:domain :OneOfPosition ; | ||
| rdfs:range :Position . | ||
|
|
||
| :probability |
There was a problem hiding this comment.
I think the probability part should come in a different pull request. I think for clean modelling it should be inverted and should not be attached to :FuzzyPosition as even an :ExactPosition can have a probability funcion associated with it.
JervenBolleman
added a commit
that referenced
this pull request
Dec 13, 2018
JervenBolleman
added a commit
that referenced
this pull request
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not straight forward to model possible positions for OneOfPosition, see #37. The new property possiblePositions makes it simpler.
The second new property for FuzzyPosition, probability, cover cases as those of PTMs in IntAct where a probability is assigned to a fuzzy position.