-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Conditionally enable the new default rendering mode for Pages #69160
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the right compromise for 6.8 and we should ship this in the Betas with a Call for testing 👍 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code logic here looks good to me 👍
Thanks everyone for the feedback 🙇 |
What?
Part of #68684.
PR updates logic to enable a new default mode for pages and only enables it for block-based themes.
Why?
See: WordPress/wordpress-develop#8123 (comment)
Testing Instructions
Using a block theme.
Using a hybrid theme.
Testing Instructions for Keyboard
Same.
Screenshots or screencast