-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Set new default rendering mode for Pages #8123
base: trunk
Are you sure you want to change the base?
Editor: Set new default rendering mode for Pages #8123
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Thanks for the fixes! 😃 |
I'm considering making the new default mode for Pages conditional and only setting it when
Is the |
Yes, I don't see why not. Given that |
Anyway, I think it would be safer to implement this step by step, and perhaps not making it the default behavior for page-like post types for now, at least in hybrid/classic themes. |
632dda6
to
1397661
Compare
Synced the latest changes from WordPress/gutenberg#69160. This is ready for testing and approval. |
@@ -69,6 +69,11 @@ function create_initial_post_types() { | |||
) | |||
); | |||
|
|||
// Enhance page editor for block themes by rendering template and content blocks. | |||
if ( wp_is_block_theme() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ( wp_is_block_theme() ) { | |
if ( wp_is_block_theme() && current_theme_supports( 'block-templates' ) ) { |
I think I'll need to harden this condition by adding a current_theme_supports
check. While it should be an edge case for a block theme not to support block-templates
, it's still technically doable. See: WordPress/gutenberg#67875 (comment).
Supersedes: #7129
Gutenberg PR: WordPress/gutenberg#68549
This update updates the
page
post-type definition and setstemplate-locked
as the new default rendering mode for the block editor.Trac ticket: https://core.trac.wordpress.org/ticket/61811
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.