[AIE2P] Add missing mac/mul frontend intrinsics #281
+16,073
−1,466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnikant
requested review from
abhinay-anubola,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
SagarMaheshwari99
force-pushed
the
aie2p.missing.mac.intrinsics
branch
from
e4ed562 to
c0bacb5
Compare
|
Can we remove all occurrences of |
|
Can we remove all the defined intrinsics from aie2p_aie_api_compat.h? |
abnikant
force-pushed
the
aie2p.missing.mac.intrinsics
branch
from
c0bacb5 to
c42e4dd
Compare
yes, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the missing mac/mul intrinsics and add llvm IR tests for aie2p sub-target.