Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIE2P] Instruction select G_SELECT. #291

Open
wants to merge 1 commit into
base: aie-public
Choose a base branch
from
Open

[AIE2P] Instruction select G_SELECT. #291

wants to merge 1 commit into from
+115 −27

Conversation

SagarMaheshwari99
Copy link
Collaborator

No description provided.

konstantinschwarz
konstantinschwarz reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@konstantinschwarz konstantinschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions to refactor some code, overall this look ok

llvm/lib/Target/AIE/AIE2InstrPatterns.td
def : Pat<(vec512Ty (select (i32 eRS8:$rs1), VEC512:$rs2, VEC512:$rs3)),
(vec512Ty (VSEL_32 VEC512:$rs2, VEC512:$rs3, (ADD_add_r_ri eR:$rs1, (i32 -1))))>;
}
foreach vec1024Ty = [v128i8, v64i16, v32i32] in {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we adapt the legalization rules for G_SELECT and clamp to 512-bit vector types?
Then we only need to support the 512-bit patterns

llvm/test/CodeGen/AIE/aie2p/GlobalIsel/inst-select-vsel.mir
@@ -166,3 +166,91 @@ body: |
$x0 = COPY %0:vregbank(<16 x s32>)
PseudoRET implicit $lr, implicit $x0
...

---
name: gselect_v8s32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have similar tests for AIE1 & AIE2. Maybe consolidate the G_SELECT tests into llvm/test/CodeGen/AIE/GlobalISel/inst-select-select.mir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstantinschwarz konstantinschwarz konstantinschwarz left review comments

@abhinay-anubola abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@andcarminati andcarminati Awaiting requested review from andcarminati andcarminati is a code owner

@gbossu gbossu Awaiting requested review from gbossu gbossu is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@martien-de-jong martien-de-jong Awaiting requested review from martien-de-jong martien-de-jong is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagarMaheshwari99 @konstantinschwarz