Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIE2P] Implemented VST.SRS combine #292

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[AIE2P] Implemented VST.SRS combine #292

merged 1 commit into from
Jan 28, 2025

Conversation

katerynamuts
Copy link
Collaborator

No description provided.

@katerynamuts katerynamuts mentioned this pull request Jan 22, 2025
Merged
mludevid
mludevid previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@mludevid mludevid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little error, then it's good to go!

llvm/lib/Target/AIE/aie2p/AIE2PInstructionSelector.cpp Outdated Show resolved Hide resolved
mludevid
mludevid previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@mludevid mludevid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mludevid mludevid mentioned this pull request Jan 22, 2025
Open
@katerynamuts katerynamuts force-pushed the kmuts.vst-srs branch 2 times, most recently from 5421553 to 40d3a36 Compare January 23, 2025 10:13
mludevid
mludevid previously approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@mludevid mludevid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llvm/lib/Target/AIE/aie2p/AIE2PInstructionSelector.cpp Outdated
(SrcRegSize == 512 || SrcRegSize == 1024)) ||
(MemOpLoadStoreSize == 512 &&
(SrcRegSize == 1024 || SrcRegSize == 2048)) &&
"Unexpected STS.SRS size");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: VST.SRS

khallouh
khallouh previously approved these changes Jan 28, 2025
View reviewed changes
@katerynamuts katerynamuts enabled auto-merge (rebase) January 28, 2025 10:06
@katerynamuts katerynamuts disabled auto-merge January 28, 2025 11:00
@katerynamuts katerynamuts merged commit 0b93802 into aie-public Jan 28, 2025
8 checks passed
@katerynamuts katerynamuts deleted the kmuts.vst-srs branch January 28, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khallouh khallouh khallouh approved these changes

@mludevid mludevid mludevid left review comments

@abhinay-anubola abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@gbossu gbossu Awaiting requested review from gbossu gbossu is a code owner

@konstantinschwarz konstantinschwarz Awaiting requested review from konstantinschwarz konstantinschwarz is a code owner

@martien-de-jong martien-de-jong Awaiting requested review from martien-de-jong martien-de-jong is a code owner

@SagarMaheshwari99 SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@F-Stuckmann F-Stuckmann Awaiting requested review from F-Stuckmann F-Stuckmann is a code owner

@niwinanto niwinanto Awaiting requested review from niwinanto niwinanto is a code owner

@andcarminati andcarminati Awaiting requested review from andcarminati andcarminati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katerynamuts @andcarminati @mludevid @khallouh