Feat: Push the lunettes image to both dockerhub and acr #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuzb
force-pushed
the
feat/aliyun-repo
branch
from
18f742c to
dad352f
Compare
linuzb
changed the title
linuzb
force-pushed
the
feat/aliyun-repo
branch
3 times, most recently
from
a5707cc to
a6c83b8
Compare
linuzb
changed the title
|
resolve #113 |
d3c3mber
reviewed
Jun 13, 2024
|
|
||
| jobs: | ||
| create-cluster: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| # Free disk space | ||
| - name: Free disk space 🧹 |
There was a problem hiding this comment.
is this icon written here on purpose :D
There was a problem hiding this comment.
This code snippet is references the usage of another project jupyter/docker-stacks, which also encounters the problem of disk full.
|
thank you @linuzb 🎉 |
d3c3mber
reviewed
Jun 13, 2024
deploy/helm/lunettes/values.yaml
Outdated
| memory: 512Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 512Mi | ||
|
|
||
| # jaejer |
There was a problem hiding this comment.
All jaejer typo have been modified
d3c3mber
reviewed
Jun 13, 2024
hack/convert-image/convert_images.sh
Outdated
| @@ -0,0 +1,64 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
maybe we can have a better word than "convert image" ?
There was a problem hiding this comment.
Replace "convet image" with "image transfer", which means that copy the image from one registry to another.
Or maybe we can name it "image syncer"?
linuzb
force-pushed
the
feat/aliyun-repo
branch
2 times, most recently
from
9fe217e to
3d3c595
Compare
Signed-off-by: linuzb <[email protected]>
Signed-off-by: linuzb <[email protected]>
Signed-off-by: linuzb <[email protected]>
Signed-off-by: linuzb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pr is to speed up the deployment of lunettes by Chinese users by pushing images to a repository deployed in China (aliyun image regitstry). Users in different regions can choose different repositories for accelerated mirror downloads.
This pr has four main changes