feat: reapply: remove default usage of parse-arguments #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
changed the title
geyslan
force-pushed
the
4541-revert-4461
branch
from
5328a48 to
3275a45
Compare
yanivagman
approved these changes
Jan 23, 2025
geyslan
force-pushed
the
4541-revert-4461
branch
2 times, most recently
from
82ac6b6 to
17aa0ea
Compare
geyslan
force-pushed
the
4541-revert-4461
branch
from
17aa0ea to
c922aaa
Compare
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4541
This reverts #4331 back.
1. Explain what the PR does
c922aaa Reapply "feat(sigs): refactor to use nonparsed arguments"
f680998 Revert "Add workaround: Revert to using raw ... argument values in engine stage".
1f00c68 chore(deps): bump signatures/helpers to f57a1eb
c922aaa Reapply "feat(sigs): refactor to use nonparsed arguments"
f680998 Revert "Add workaround: Revert to using raw ... argument values in engine stage".
2. Explain how to test it
3. Other comments