feat(helpers): reapply: unparsed flag helpers #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flag helpers previously took a string argument to test against possible flag configurations. New implementation takes the integer form and makes the test with the bit flag directly. It makes use of syscall package to get constants for the flags instead of Tracee's parsers package. Co-authored-by: Geyslan Gregório <[email protected]>
|
I've cancelled the tests since the change is not reflect on main go.mod yet. |
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Jan 23, 2025
flag helpers previously took a string argument to test against possible flag configurations. New implementation takes the integer form and makes the test with the bit flag directly. It makes use of syscall package to get constants for the flags instead of Tracee's parsers package. Co-authored-by: Nadav Strahilevitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #4541 to make possible to merge #4544.
1. Explain what the PR does
ed62bef feat(helpers): unparsed flag helpers
2. Explain how to test it
3. Other comments