Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sqlalchemy version #970

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Nov 8, 2024

Fixes #931

Description

The upgrade path from sqlalchemy 1.4 -> 2.0 was designed to have a seamless upgrade path. This PR updates:

Docs: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#the-1-4-2-0-migration-path

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit f016817
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/672e989dce494b0008c20736

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 98ae25a
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/673bb3273003fe0008a3271e
😎 Deploy Preview https://deploy-preview-970--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soapy1 soapy1 marked this pull request as ready for review November 8, 2024 23:34
@soapy1 soapy1 requested a review from peytondmurray November 8, 2024 23:34
@soapy1 soapy1 marked this pull request as draft November 14, 2024 17:42
The upgrade path from sqlalchemy 1.4 -> 2.0 was designed to have
a seamless upgrade path.
Docs: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#the-1-4-2-0-migration-path
@soapy1 soapy1 force-pushed the upgrade-sqlalchemy branch from 7980241 to 3d80318 Compare November 14, 2024 22:30
@soapy1 soapy1 marked this pull request as ready for review November 14, 2024 22:46
@soapy1 soapy1 marked this pull request as draft November 18, 2024 19:16
@soapy1 soapy1 force-pushed the upgrade-sqlalchemy branch from 9ee1ef2 to 762477b Compare November 18, 2024 21:35
@soapy1 soapy1 marked this pull request as ready for review November 18, 2024 21:39
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - the tests will tell us whether there were any issues with the annotations. A few other minor comments, but on the whole this is brilliant - thank you! 🚀

@peytondmurray peytondmurray merged commit afc4908 into conda-incubator:main Nov 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[MAINT] - sqlalchemy 2.0 migration
2 participants