[WASI] HTTP trailers #107795
Closed
[WASI] HTTP trailers #107795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to this area: @dotnet/ncl |
dicej
approved these changes
Sep 13, 2024
src/libraries/System.Net.Http/src/System/Net/Http/WasiHttpHandler/WasiInputStream.cs
Outdated
Show resolved
Hide resolved
This was referenced Sep 13, 2024
pavelsavara
commented
Sep 16, 2024
| using (HttpClient httpClient = new HttpClient()) | ||
| { | ||
| httpClient.DefaultRequestVersion = HttpVersion.Version20; | ||
| httpClient.DefaultRequestHeaders.Add("TE", "trailers"); |
There was a problem hiding this comment.
Understandably the line with HttpVersion.Version20 doesn't do anything right now.
But I'm getting ITypes.HeaderError.FORBIDDEN from wasmtime v24 for setting TE header. Am I doing it wrong ?
I remeber there was some discussion about it, but can't find it now.
pavelsavara
added
the
NO-MERGE
|
This is blocked until wasmtime allows sending |
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on WebAssembly/wasi-http#128
Related by not ideal WebAssembly/wasi-http#129