Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] Add "pyyaml==6.0.1" dependency to Dockerfile #6

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

iksnagreb
Copy link

More of a personal preference, but I assume I am not alone. I like to specify my model or "experiment" configurations as well as the metrics collected in YAML format instead of JSON, see here for an example: https://github.com/iksnagreb/attention-dummy/blob/benchmark/params.yaml

I think it does not hurt to add a YAML parser into the finn container, at least it should not interfere with anything else and I do not expect frequent changes to this dependency either.

See Xilinx#966

@bwintermann
Copy link

This seems to crash with the changes that you did with the VitisOptStrategy enum @LinusJungemann, can you take a look?

@iksnagreb
Copy link
Author

Oh, no, you should not have merged our dev here, this is a mirror of the upstream PR, you now extended my existing PR to Xilinx/dev to also include our dev... This one should have actually just been a single line to Dockerfile (+ the recent upstream dev, which we would have synchronized anyway soon...). Was there actually a conflict you tried to resolve by merging dev?

@bwintermann
Copy link

Oh damn sorry overlooked this. No I just wanted to sync the part_map line which I mistakenly thought would already be in our dev too but didn't see it was from your own repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants