fix: Fix return value for useAllPersonDetailsAsync (#1122)

* fix: Fix return value for useAllPersonDetailsAsync
equinor · Apr 26, 2024 · f8c8145 · f8c8145
1 parent 9e016aa
commit f8c8145
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/frontend/src/components/Action/CreateForm/ActionCreateForm.tsx b/frontend/src/components/Action/CreateForm/ActionCreateForm.tsx
@@ -13,7 +13,7 @@ import { PersonDetails } from '@equinor/fusion-react-person'
 interface Props {
     connectedQuestion: Question
     possibleAssignees: Participant[]
-    possibleAssigneesDetails: any[] // PersonDetails[]
+    possibleAssigneesDetails: PersonDetails[]
     onActionCreate: (action: DataToCreateAction) => void
     onCancelClick: () => void
     disableCreate: boolean
@@ -41,7 +41,7 @@ const ActionCreateForm = ({
     const [description, setDescription] = useState<string>('')
 
     const assigneesOptions = possibleAssigneesDetails.map(personDetails => ({
-        id: personDetails?.azureUniqueId,
+        id: personDetails?.azureId,
         title: personDetails?.name,
     }))
 

diff --git a/frontend/src/components/Action/EditForm/ActionEditForm.tsx b/frontend/src/components/Action/EditForm/ActionEditForm.tsx
@@ -38,7 +38,7 @@ interface Props {
     action: Action
     connectedQuestion: Question
     possibleAssignees: Participant[]
-    possibleAssigneesDetails: any[] // PersonDetails[]
+    possibleAssigneesDetails: PersonDetails[]
     onEditShouldDelay: (action: Action, isValid: boolean) => void
     onEditShouldNotDelay: (action: Action, isValid: boolean) => void
     createClosingRemark: (text: string) => void
@@ -79,7 +79,7 @@ const ActionEditForm = ({
         useShowErrorHook(apiErrorClosingRemark)
 
     const assigneesOptions = possibleAssigneesDetails.map(personDetails => ({
-        id: personDetails.azureUniqueId,
+        id: personDetails.azureId,
         title: personDetails.name,
     }))
 

diff --git a/frontend/src/utils/hooks.ts b/frontend/src/utils/hooks.ts
@@ -32,7 +32,10 @@ export const useAllPersonDetailsAsync = (azureUniqueIds: string[]): PersonDetail
     const getAllPersonDetails = async (azureUniqueIds: string[]): Promise<PersonDetails[]> => {
         const manyPromises: Promise<PersonDetails>[] = azureUniqueIds.map(azureUniqueId => {
             return apiClients.getById(azureUniqueId).then(response => {
-                return response
+                return {
+                    azureId: response.azureUniqueId,
+                    name: response.name,
+                }
             })
         })